feat!: update to noir_bignum v0.4.0 (#10)

* update to be compatible with latest bignum

* bump test version

* chore: use v0.4.1 release of bignum

* fix: remove unnecessary generic

---------

Co-authored-by: Tom French <tom@tomfren.ch>

.github/NIGHTLY_CANARY_DIED.md

@@ -1,8 +1,8 @@
 ---
 title: "Tests fail on latest Nargo nightly release"
-assignees: TomAFrench
+assignees: TomAFrench, kashbrti, jtriley-eth
 ---
 
 The tests on this Noir project have started failing when using the latest nightly release of the Noir compiler. This likely means that there have been breaking changes for which this project needs to be updated to take into account.
 
-Check the [{{env.WORKFLOW_NAME}}]({{env.WORKFLOW_URL}}) workflow for details.
+Check the [{{env.WORKFLOW_NAME}}]({{env.WORKFLOW_URL}}) workflow for details.

.github/workflows/test.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        toolchain: [nightly, 0.35.0]
+        toolchain: [nightly, 0.36.0]
     steps:
       - name: Checkout sources
         uses: actions/checkout@v4
@@ -38,7 +38,30 @@ jobs:
       - name: Install Nargo
         uses: noir-lang/noirup@v0.1.3
         with:
-          toolchain: 0.35.0
+          toolchain: 0.36.0
 
       - name: Run formatter
         run: nargo fmt --check
+
+  # This is a job which depends on all test jobs and reports the overall status.
+  # This allows us to add/remove test jobs without having to update the required workflows.
+  tests-end:
+    name: Noir End
+    runs-on: ubuntu-latest
+    # We want this job to always run (even if the dependant jobs fail) as we want this job to fail rather than skipping.
+    if: ${{ always() }}
+    needs: 
+      - test
+      - format
+
+    steps:
+      - name: Report overall success
+        run: |
+          if [[ $FAIL == true ]]; then
+              exit 1
+          else
+              exit 0
+          fi
+        env:
+          # We treat any cancelled, skipped or failing jobs as a failure for the workflow as a whole.
+          FAIL: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'skipped') }}

Nargo.toml

@@ -2,8 +2,8 @@
 name = "noir_bigcurve"
 type = "lib"
 authors = [""]
-compiler_version = ">=0.35.0"
+compiler_version = ">=0.36.0"
 
 [dependencies]
-bignum = {tag = "v0.3.7", git = "https://github.com/noir-lang/noir-bignum"}
-sort = {tag = "v0.1.0", git = "https://github.com/noir-lang/noir_sort"}
+bignum = {tag = "v0.4.1", git = "https://github.com/noir-lang/noir-bignum"}
+sort = {tag = "v0.2.0", git = "https://github.com/noir-lang/noir_sort"}