Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Tests #13

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: Update Tests #13

wants to merge 10 commits into from

Conversation

jtriley-eth
Copy link

Description

Remove tests from impl blocks, dedupe test names.

Additional Context

Tests now fail for msm on Secp256r1, MNT6_753, MNT4_753, and Secp384r1 curves. I'm unsure what msm means, but the error originates in the Curve::evaluate_linear_expression method and fails in __compute_quadratic_expression_with_borrow_flags from the noir-bignum library, specifically:

assert(remainder == [0; N]);

@kashbrti kashbrti changed the title Update Tests fix: Update Tests Nov 28, 2024
@kashbrti kashbrti marked this pull request as ready for review November 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants