Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the reason is never an empty string, but None in HTTP responses #1063

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Ensure the reason is never an empty string, but None in HTTP responses #1063

merged 1 commit into from
Oct 8, 2023

Commits on Oct 8, 2023

  1. Ensure the reason is never an empty string, but None in HTTP responses 

    Otherwise, `aiohttp` (in tests) cannot parse the response with the trailing space in the status — `"HTTP/1.1 555 "` — since `"555 ".split()` returns only one element, and the whole string `"555 "` is used as the status with expectations of being a 3-digit numeric.

For some reason, the tests fail with this only in PyPy (all versions).

Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
    @nolar
    nolar committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    0941153 View commit details
    Browse the repository at this point in the history