Skip to content

Conversation

@liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Sep 21, 2025

Explain the Changes

Bumping version from 5.20.0 to 5.21.0

Summary by CodeRabbit

  • Chores
    • Incremented application version to 5.21.0 to align with release cycle and dependency management; no modifications to features, UI, performance, or behavior included in this update. This change prepares the project for the next release and distribution processes. No action required for users beyond standard update; backward compatibility maintained. No downtime expected.

Bumping version from 5.20.0 to 5.21.0

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Sep 21, 2025

Walkthrough

Version field in package.json updated from 5.20.0 to 5.21.0.

Changes

Cohort / File(s) Summary
Package metadata
package.json
Bumped version from 5.20.0 to 5.21.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • nimrod-becker
  • tangledbytes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Bumping version from 5.20.0 to 5.21.0" directly and concisely describes the primary change in the changeset (the package.json version bump), is a single clear sentence, and contains no noisy or misleading language.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6737586 and 440abe0.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build Noobaa Image
  • GitHub Check: run-package-lock-validation
  • GitHub Check: run-jest-unit-tests
🔇 Additional comments (3)
package.json (3)

3-3: Version bump looks good and matches PR intent.

No side effects in this file. Safe to merge as a pure metadata update.


3-3: Confirm downstream release artifacts pick up package.json version 5.21.0

If CI uses package.json.version for image tags / binaries / Docker LABELs / release notes, confirm they emit 5.21.0 (not a cached value). Update CHANGELOG/Release notes if that’s part of the process.

Run this verification locally (avoids process-substitution issues):

#!/bin/bash
set -euo pipefail

# repo-root package.json version
if [ -f package.json ]; then
  if command -v jq >/dev/null 2>&1; then
    echo "package.json version: $(jq -r .version package.json)"
  else
    grep -n '"version"' package.json || true
  fi
else
  echo "package.json not found at repo root"
fi

# find literal mentions of the new version
if command -v rg >/dev/null 2>&1; then
  rg -n --hidden -uu '5\.21\.0' || true
else
  grep -RIn --binary-files=without-match --exclude-dir=node_modules '5\.21\.0' . || true
fi

# search common embedding points
if command -v rg >/dev/null 2>&1; then
  rg -n --hidden -uu '(LABEL version=|NOOBAA_?VERSION|image:|pkg )' -g '!node_modules/**' || true
else
  grep -RIn --binary-files=without-match --exclude-dir=node_modules -e 'LABEL version=' -e 'NOOBAA_VERSION' -e 'NOOBAA-VERSION' -e 'image:' -e 'pkg ' . || true
fi

# locate CHANGELOG files
find . -type f \( -iname 'CHANGELOG' -o -iname 'CHANGELOG.md' -o -iname 'CHANGELOG.rst' \) -print -exec sed -n '1,120p' {} \; || true

3-3: Lockfile updated — fix remaining 5.20.0 references

  • package-lock.json is 5.21.0 (OK).
  • Found 5.20.0 references — update or confirm intentional:
    • src/test/integration_tests/internal/test_upgrade_scripts.js: require('../../../upgrade/upgrade_scripts/5.20.0/remove_mongo_pool') (line 15); mocha.it('test remove mongo_pool to version 5.20.0', ...) (line 136).
    • docs/NooBaaNonContainerized/GettingStarted.md: wget .../noobaa-core-5.20.0-20250810-master.el9.x86_64.rpm (line 280).
  • Action: update these to 5.21.0 if they should follow the bump; if they intentionally reference older releases (e.g. upgrade tests), leave as-is and document that in the PR.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@liranmauda liranmauda merged commit 19e08e0 into noobaa:master Sep 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants