Transition to new JSON based syntax color scheme format #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Sublime Text 3 build 3149, a new JSON based color scheme format `.sublime-color-scheme` was introduced for easier editing, customization and addition of new features. The documentation for the new format is available at the main "Color Schemes" documentation (1). Nord will migrate to the new format (JSON) from the now deprecated/legacy `.tmTheme` format (XML). All versions greater or equal to 3.1 build 3120 come with a builtin tool to convert legacy themes to the new format through the command palette only when the files is opened in the editor**: „Convert Color Scheme“ The foloowing additional changes and additions for features that have been introduced withg the new JSON color scheme format are included: - Added all Nord colors as variables to the `variables` object that are exposed through Sublime Text's internal CSS color scheme API to reuse them with the CSS `var()` function for the defined scope rules. - Added additional syntax-specific variables to the `variables` object to ensure a uniform color usage for scopes with the same context as well as reducing code duplication and possible transmission errors. - Added the new Git gutter diff keys `line_diff_added`, `line_diff_modified` and `line_diff_deleted` to the `globals` object to ensure they match Nord's style. (@kaine119) The now officially deprecated `.tmTheme` color scheme format file (2) has been removed and is not supported by the Nord theme package anymore. References: (1) https://www.sublimetext.com/docs/3/color_schemes.html (2) https://www.sublimetext.com/docs/3/color_schemes_tmtheme.html Co-authored-by: Kai En <muikaien1@gmail.com> Merged with GH-20 GH-22
svengreb
approved these changes
Aug 6, 2019
arcticicestudio
deleted the
feature/gh-22-transition-json-color-scheme-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Sublime Text 3 build 3149, a new JSON based color scheme format
.sublime-color-schemewas introduced for easier editing, customization and addition of new features. The documentation for the new format is available at the main "Color Schemes" documentation.This PR migrates Nord to the new format (JSON) from the now deprecated/legacy
.tmThemeformat (XML).All versions greater or equal to 3.1 build 3120 come with a builtin tool to convert legacy themes to the new format through the command palette only when the files is opened in the editor**: „Convert Color Scheme“
The following additional changes and additions for features that have been introduced with the new JSON color scheme format are included:
variablesobject that are exposed through Sublime Text's internal CSS color scheme API to reuse them with the CSSvar()function for the defined scope rules.variablesobject to ensure a uniform color usage for scopes with the same context as well as reducing code duplication and possible transmission errors.line_diff_added,line_diff_modifiedandline_diff_deletedto theglobalsobject to ensure they match Nord's style. (@kaine119)The now officially deprecated
.tmThemecolor scheme format file has been removed and is not supported by the Nord theme package anymore.