Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpIteration TransformationParameters incorrect frame #590

Open
ryancu7 opened this issue Dec 6, 2024 · 0 comments
Open

dumpIteration TransformationParameters incorrect frame #590

ryancu7 opened this issue Dec 6, 2024 · 0 comments

Comments

@ryancu7
Copy link

ryancu7 commented Dec 6, 2024

Usage scenario: C++ with custom Inspector subclass with dumpIteration override.

The final TransformationParameters returned by the ICP call can be different to the TransformationParameters provided in the last dumpIteration callback even when convergence was reached. It also looks like the transformation passed to dumpIteration does not match the transformation applied to the "Reading" DataPoints.

Looking at ICP.cpp, the issue seems to be that the Parameters argument of the dumpIteration callback is passed T_iter which is in refMean frame, which the documentation does not warn about, and refMean is not made available separately for applying in the callback anyway. I would expect the frame of the dumpIteration transformation to match that of the final ICP() call result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant