Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-router to v4.1.1 #705

Closed
lpirola opened this issue Jun 23, 2017 · 2 comments
Closed

Upgrade react-router to v4.1.1 #705

lpirola opened this issue Jun 23, 2017 · 2 comments
Assignees

Comments

@lpirola
Copy link
Contributor

lpirola commented Jun 23, 2017

Related pull-requests

Description

It needs to upgrade the react-router package to v4.1.1 , that was indicated by greenkeeper bot. Make the necessary changes on the project to not break the project with this upgrade.

@igr-santos
Copy link
Contributor

@igr-santos
Copy link
Contributor

Change following files to use react-router-redux redirect:

  • ./client/account/redux/action-creators/async-retrieve-password.js:21: browserHistory.push(paths.login())
  • ./client/account/redux/action-creators/logout.js:8: browserHistory.push('/login')
  • ./client/mobrender/components/mobilization.js:34: browserHistory.push(paths.mobilizationTemplatesChoose(mobilization))
  • ./client/mobrender/components/widget.js:34: browserHistory.push(redirect)
  • ./client/mobilizations/widgets/__plugins__/donation/components/__donation__/index.js:46: browserHistory.push(paths.donation(mobilization.id, widget.id))
  • ./client/mobilizations/widgets/__plugins__/pressure/components/__pressure__.js:65: browserHistory.push(
  • ./client/mobilizations/widgets/__plugins__/form/components/__form__.js:40: browserHistory.push(paths.fieldsMobilizationWidget(mobilization.id, widget.id))
  • ./routes/admin/not-authenticated/account-login/page.connected.js:51: browserHistory.push('/')
  • ./routes/admin/not-authenticated/account-register/page.js:20: browserHistory.push(Paths.login())
  • ./routes/admin/authenticated/sidebar/mobilizations-launch/page.js:78: browserHistory.push(
  • ./routes/admin/authenticated/sidebar/community-settings/domain-create/page.js:102: onClick={() => browserHistory.push(paths.communityDomain())}
  • ./routes/admin/authenticated/sidebar/community-settings/domain-create/page.js:168: onClick={() => browserHistory.push(paths.communityDomain())}
  • ./routes/admin/authenticated/sidebar/community-settings/domain-create/page.js:180: browserHistory.push(query.next)
  • ./routes/admin/authenticated/sidebar/community-settings/domain-create/page.js:222: onClick={() => browserHistory.push(paths.communityDomain())}
  • ./routes/admin/authenticated/sidebar/community-settings/domain/page.js:189: onClick={() => browserHistory.push(Paths.communityDomainCreate())}
  • ./routes/admin/authenticated/sidebar/mobilizations-edit/page.js:18: browserHistory.push(paths.createBlock(mobilization))
  • ./routes/admin/authenticated/sidebar/mobilizations-launch-end/page.js:31: <Button onClick={() => browserHistory.push(paths.editMobilization(id))}>
  • ./routes/admin/authenticated/sidebar/blocks-create/page.js:141: browserHistory.push(
  • ./routes/admin/authenticated/sidebar/templates-choose-global/page.js:19: handleGoBack={() => browserHistory.push(paths.mobilizationTemplatesChoose(mobilization))}
  • ./routes/admin/authenticated/sidebar/templates-choose-global/page.js:23: browserHistory.push(paths.editMobilization(mobilization.id))
  • ./routes/admin/authenticated/sidebar/mobilizations-new/page.js:16: mobilization && browserHistory.push(
  • ./routes/admin/authenticated/sidebar/templates-choose-custom/page.js:23: browserHistory.push(paths.editMobilization(mobilization.id))
  • ./routes/admin/authenticated/sidebar/mobilizations-settings-domain/page.js:19: redirectToCreateDNS={() => browserHistory.push(paths.communityDomainCreate())}
  • ./routes/admin/authenticated/sidebar/mobilizations-list/page.js:35: browserHistory.push(paths.editMobilization(mobilization.id))
  • ./routes/admin/authenticated/sidebar/templates-create/page.js:42: browserHistory.push(paths.mobilizations())
    -./routes/admin/authenticated/logout/page.js:10: this.props.logout().then(() => browserHistory.push(Paths.login()))
    -./routes/admin/authenticated/external/community-list/page.js:12: browserHistory.push(paths.communityAdd())
  • ./routes/admin/authenticated/external/community-list/page.js:18: browserHistory.push(paths.mobilizations())
  • ./routes/admin/authenticated/external/community-new/page.js:20: browserHistory.push(paths.communityList())

@gabrielrtakeda gabrielrtakeda modified the milestones: v0.5.10, v0.5.11 Jun 30, 2017
@gabrielrtakeda gabrielrtakeda changed the title Upgrade react-router Upgrade react-router to v4.1.1 Jun 30, 2017
@lpirola lpirola modified the milestones: v0.5.11, v0.6.2 Jul 3, 2017
@lpirola lpirola modified the milestone: v0.6.2 Aug 21, 2017
@lpirola lpirola closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants