Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency injection of remote store for NotaryRepository initial… #1094

Merged
merged 13 commits into from
Mar 1, 2017
Merged

Add dependency injection of remote store for NotaryRepository initial… #1094

merged 13 commits into from
Mar 1, 2017

Commits on Feb 25, 2017

  1. Add dependency injection of remote store for NotaryRepository initial… 

    …ization

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    ddfe727 View commit details
    Browse the repository at this point in the history

  2. Remove helper and test for changing remote store base URL once instan… 

    …tiated

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    e4cacd0 View commit details
    Browse the repository at this point in the history

  3. Remove the RoundTripper object out of NotaryRepository 

    Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    ae43610 View commit details
    Browse the repository at this point in the history

  4. making changelist injectable 

    Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
    @n4ss
    David Lawrence authored and n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    7d8ec9f View commit details
    Browse the repository at this point in the history

  5. fixing an ineffassign error 

    Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
    @n4ss
    David Lawrence authored and n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    1070d54 View commit details
    Browse the repository at this point in the history

  6. Minor fixes from reviews 

    Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    e8d8eae View commit details
    Browse the repository at this point in the history

  7. Add a getter for RemoteStore of a repo returning a valid remote store… 

    … or an OfflineStore

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    144a9ad View commit details
    Browse the repository at this point in the history

  8. Minor gofmt fix 

    Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 25, 2017
    Configuration menu
    Copy the full SHA
    1d03a50 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2017

  1. Remove unncesserary error return value from repo's remoteStore getter 

    Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    9b5aeb7 View commit details
    Browse the repository at this point in the history

  2. Let getRemoteStore helper function caller decide wether to log and ex… 

    …it on error or not

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    10577ed View commit details
    Browse the repository at this point in the history

  3. Remove export of repo's remoteStore getter 

    Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    1afae72 View commit details
    Browse the repository at this point in the history

  4. Error on invalid baseURL for a remote store 

    Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    0b3f3cb View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2017

  1. Remove unnecessary error logging on invalid repo baseURL 

    Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
    @n4ss
    n4ss committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    b70d671 View commit details
    Browse the repository at this point in the history