Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tsa cert chain revocation check after timestamping #246

Merged
merged 9 commits into from
Nov 29, 2024
Merged

fix: add tsa cert chain revocation check after timestamping #246

merged 9 commits into from
Nov 29, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Nov 21, 2024 •
edited
Loading

This PR adds an option to enable tsa certificate chain revocation check after timestamping during signing.

Resolves #237

@Two-Hearts
timestamping
0fcd116 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (ce88e08) to head (91c5e83).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   91.79%   92.02%   +0.23%     
==========================================
  Files          30       31       +1     
  Lines        2607     2645      +38     
==========================================
+ Hits         2393     2434      +41     
+ Misses        163      161       -2     
+ Partials       51       50       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Nov 21, 2024
View reviewed changes
x509/helper.go Outdated Show resolved Hide resolved
signature/types.go Outdated Show resolved Hide resolved
@Two-Hearts
update
b606f89 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update revocation result check
7a31925 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
refactor
3ef5c27 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
refactoring
45c0fa2 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
ff74cc7 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
106e821 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi reviewed Nov 28, 2024
View reviewed changes
internal/timestamp/timestamp.go Outdated Show resolved Hide resolved
internal/timestamp/timestamp.go Outdated Show resolved Hide resolved
internal/timestamp/timestamp.go Show resolved Hide resolved
@Two-Hearts
update
91c5e83 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
priteshbandi
priteshbandi approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 95d8954 into notaryproject:main Nov 29, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the timestamping branch November 29, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSA certificate chain revocation check after timestamping
4 participants
@Two-Hearts @priteshbandi @shizhMSFT @JeyJeyGao