Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved configuration #148

Merged
merged 7 commits into from
Sep 24, 2022
Merged

Improved configuration #148

merged 7 commits into from
Sep 24, 2022

Commits on Sep 24, 2022

  1. change(env): Improved environment parsing 

    getEnvRaw: `getEnvRaw` is essentially the same as `getEnv`, but much more safe as it doesn't automatically convert types - parsing is left to the consuming code.
parseBool: `parseBool` is a much more accepting function for parsing booleans. `true`, `1`, `yes`, and `on` are treated as `true`, and conversely, `false`, `0`, `no`, and `off` are treated as `false`.
    @tecc
    tecc committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    b3246a8 View commit details
    Browse the repository at this point in the history

  2. change(config): Add proxyAttachments config value. 

    proxyAttachments: `proxyAttachments` is the equivalent of `DIRECT_RESPONSE_ATTACHMENT`.
[...file].ts: Replaced direct usage of `getEnv` with new config system.
    @tecc
    tecc committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    d82c710 View commit details
    Browse the repository at this point in the history

  3. docs(config): More documentation for config/compatibility.yml 

    forcePathStyle: Added missing field of `forcePathStyle`.
proxyAttachments: Added documentation for `proxyAttachments`.
    @tecc
    tecc committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    777f958 View commit details
    Browse the repository at this point in the history

  4. change(config): Add server field to config 

    server: The `server` field will just contain things related to the server. I dunno how to explain it, but it's for that.
useSecureCookies: `server.useSecureCookies` is the equivalent of `COOKIE_SECURE`.
config/compatibility.yml: Add documentation for the new `server` field.
    @tecc
    tecc committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    c83f552 View commit details
    Browse the repository at this point in the history

  5. change(env): Mark getEnv as deprecated 

    deprecation: Well, it is. `getEnv` is too direct. It's not really a good system.
    @tecc
    tecc committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    5fcd9ea View commit details
    Browse the repository at this point in the history

  6. change(env): Replace remaining usages of getEnv

    @tecc
    tecc committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    6fb14e6 View commit details
    Browse the repository at this point in the history

  7. change(env): Move config().baseUrl to config().server.baseUrl 

    config/compatibility.yml: Updated the example to reflect how the config actually works.
move-to-server: It feels nicer to have it inside the `server` field.
    @tecc
    tecc committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    ad662af View commit details
    Browse the repository at this point in the history