Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Microsoft.SourceLink.GitHub version #333

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

vinibeloni
Copy link
Contributor

Description

Upgrade Microsoft.SourceLink.GitHub package version to 1.1.1

Fixes #332

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I just run dotnet build because this package has no code impact.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link
Contributor

@KoditkarVedant KoditkarVedant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KoditkarVedant
Copy link
Contributor

@vinibeloni Someone already asked to work on it - let me see if they still want to else, I'll accept your change.

@vinibeloni
Copy link
Contributor Author

vinibeloni commented Oct 4, 2022

@vinibeloni Someone already asked to work on it - let me see if they still want to else, I'll accept your change.

thanks! I will wait, of course.

Edit: I decided to work on this because the guy who answered the issue doesn't have a fork.

@vinibeloni
Copy link
Contributor Author

@KoditkarVedant can you merge please?

@KoditkarVedant KoditkarVedant merged commit ab0148c into notion-dotnet:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest version of Microsoft.SourceLink.GitHub
2 participants