From c6ed4e6b6b1f83fc9567b890cbcc7b58f7239325 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sun, 17 Jun 2018 01:28:09 +0530 Subject: [PATCH 01/18] Getting Ready for feedback Fix Local Build Fix NuSpec less packaging Upstream (build env) patches - SourceControlInformation fix - Add some Labels --- .editorconfig | 6 ++- Directory.Build.targets | 2 +- Source/Directory.Build.props | 6 +-- Source/Directory.Build.targets | 10 +---- .../MSBuild.Sdk.Extras.csproj | 2 +- .../MSBuild.Sdk.Extras.nuspec | 9 ++-- TestProjects/Directory.Build.props | 6 +-- TestProjects/Directory.Build.targets | 2 +- Tools/MSBuild.Packaging.targets | 44 +++++++++++-------- Tools/Sign-Package.ps1 | 10 ++--- 10 files changed, 49 insertions(+), 48 deletions(-) diff --git a/.editorconfig b/.editorconfig index 19693c8..e86a51e 100644 --- a/.editorconfig +++ b/.editorconfig @@ -6,6 +6,7 @@ root = true # Don't use tabs for indentation. [*] +charset = utf-8 indent_style = space # (Please don't specify an indent_size here; that has too many unintended consequences.) @@ -17,7 +18,10 @@ indent_size = 4 # Code files [*.{cs,csx,vb,vbx}] indent_size = 4 -charset = utf-8-bom + +# Script files +[*.{cmd,bat,ps1}] +indent_size = 4 # Xml project files [*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}] diff --git a/Directory.Build.targets b/Directory.Build.targets index 859ccb0..4d0798c 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -6,6 +6,6 @@ $(DefaultItemExcludes)$(_ProjectItemExcludes) - + \ No newline at end of file diff --git a/Source/Directory.Build.props b/Source/Directory.Build.props index 595f821..340f460 100644 --- a/Source/Directory.Build.props +++ b/Source/Directory.Build.props @@ -2,9 +2,9 @@ - + - + ~Packages @@ -15,8 +15,8 @@ true false - true true + true diff --git a/Source/Directory.Build.targets b/Source/Directory.Build.targets index 96b2534..89438ae 100644 --- a/Source/Directory.Build.targets +++ b/Source/Directory.Build.targets @@ -1,6 +1,6 @@ - + @@ -12,14 +12,8 @@ + - - true - - - - - \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj b/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj index 7fe0492..8216249 100644 --- a/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj +++ b/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj @@ -12,7 +12,7 @@ - + diff --git a/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.nuspec b/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.nuspec index 6c3218b..f96f878 100644 --- a/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.nuspec +++ b/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.nuspec @@ -12,17 +12,14 @@ $licenseUrl$ $projectUrl$ $releaseNotes$ - + false true - + - - - - + \ No newline at end of file diff --git a/TestProjects/Directory.Build.props b/TestProjects/Directory.Build.props index dd3fe21..da852df 100644 --- a/TestProjects/Directory.Build.props +++ b/TestProjects/Directory.Build.props @@ -2,14 +2,14 @@ - + $(SolutionDir) $(SolutionDir) - + - + $(BuildToolsPath)MSBuild.OutputPaths.targets diff --git a/TestProjects/Directory.Build.targets b/TestProjects/Directory.Build.targets index 1ca2ef4..8c8673a 100644 --- a/TestProjects/Directory.Build.targets +++ b/TestProjects/Directory.Build.targets @@ -1,6 +1,6 @@ - + NIRIN Nirmal Guru © NIRIN Foundation. diff --git a/Tools/MSBuild.Packaging.targets b/Tools/MSBuild.Packaging.targets index 9e3edeb..9377769 100644 --- a/Tools/MSBuild.Packaging.targets +++ b/Tools/MSBuild.Packaging.targets @@ -1,36 +1,32 @@ - - false - true - - Full - - MSBuildSdk <_DefaultTags>msbuild;sdk;dotnet $(_DefaultTags);$(PackageTags) $(_DefaultTags) - true true + true - + + false false false **\*$(DefaultLanguageSourceExtension) + true + + Full - - - + + + - - + + - InitializeSourceControlInformationFromSourceControlManager; BuildOnlySettings; PrepareForBuild; PreBuildEvent; @@ -42,15 +38,25 @@ - - $(MSBuildProjectDirectory)\$(MSBuildProjectName).nuspec + + + InitializeSourceControlInformation;$(CoreBuildDependsOn) + + + + $(MSBuildProjectName).nuspec - + $(GenerateNuspecDependsOn);SetNuSpecProperties - + + + + 0 + + id=$(PackageId); diff --git a/Tools/Sign-Package.ps1 b/Tools/Sign-Package.ps1 index 97a4e82..b7ecd59 100644 --- a/Tools/Sign-Package.ps1 +++ b/Tools/Sign-Package.ps1 @@ -4,8 +4,8 @@ $repoDirectory = "$currentDirectory\..\" # See if we have the ClientSecret available if ([string]::IsNullOrEmpty($env:SignClientSecret)) { - Write-Host "Client Secret not found, not signing packages" - return; + Write-Host "Client Secret not found, not signing packages" + return; } & nuget install SignClient -Version 0.9.1 -SolutionDir "$repoDirectory" -Verbosity quiet -ExcludeVersion @@ -17,9 +17,9 @@ $appPath = "$repoDirectory\packages\SignClient\tools\netcoreapp2.0\SignClient.dl $nupgks = Get-ChildItem $Env:ArtifactDirectory\*.nupkg | Select-Object -ExpandProperty FullName foreach ($nupkg in $nupgks) { - Write-Host "Submitting $nupkg for signing" - dotnet $appPath 'sign' -c $appSettings -i $nupkg -r $env:SignClientUser -s $env:SignClientSecret -n 'MSBuild.Sdk.Extras' -d 'MSBuild.Sdk.Extras' -u 'https://github.com/onovotny/MSBuildSdkExtras' - Write-Host "Finished signing $nupkg" + Write-Host "Submitting $nupkg for signing" + dotnet $appPath 'sign' -c $appSettings -i $nupkg -r $env:SignClientUser -s $env:SignClientSecret -n 'MSBuild.Sdk.Extras' -d 'MSBuild.Sdk.Extras' -u 'https://github.com/onovotny/MSBuildSdkExtras' + Write-Host "Finished signing $nupkg" } Write-Host "Sign-package complete" \ No newline at end of file From 6541277c504ffa0d49b3368eb25b4b2351b30fb8 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Wed, 20 Jun 2018 12:49:08 +0530 Subject: [PATCH 02/18] Removed _SdkVisualStudioVersion workaround No Longer needed since we need VS/MSBuild 15 and above Silverlight and WP targets are not affected! --- .../Build/LanguageTargets/Desktop.targets | 10 +++++----- .../Build/LanguageTargets/Portable.targets | 4 ++-- .../Build/LanguageTargets/Windows.targets | 2 +- .../Build/MSBuild.NET.Extras.Sdk.props | 4 ++++ .../Build/MSBuild.NET.Extras.Sdk.targets | 5 ----- 5 files changed, 12 insertions(+), 13 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets index dccb0e1..66bd612 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets @@ -5,12 +5,12 @@ - - <_SdkDesktopTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\$(_SdkVisualStudioVersion)\Bin\Microsoft.$(_LanguageSourceName).targets - <_SdkDesktopTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(_SdkVisualStudioVersion)\FSharp\Microsoft.FSharp.Targets + + <_SdkDesktopTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\$(VisualStudioVersion)\Bin\Microsoft.$(_LanguageSourceName).targets + <_SdkDesktopTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets index 3fad9ca..c1a854d 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets @@ -4,9 +4,9 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) - + <_SdkPortableTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\Portable\$(TargetFrameworkVersion)\Microsoft.Portable.$(_LanguageSourceName).targets - <_SdkPortableTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(_SdkVisualStudioVersion)\FSharp\Microsoft.Portable.FSharp.Targets + <_SdkPortableTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.Portable.FSharp.Targets diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets index cb4704b..22f3152 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets @@ -5,7 +5,7 @@ - <_SdkWindowsTargets Condition="'$(_SdkWindowsTargets)' == ''">$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(_SdkVisualStudioVersion)\Microsoft.Windows.UI.Xaml.$(_LanguageSourceName).targets + <_SdkWindowsTargets Condition="'$(_SdkWindowsTargets)' == ''">$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.$(_LanguageSourceName).targets <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkWindowsTargets)')">true diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props index 0d2fa46..2d8a3a5 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props @@ -40,6 +40,10 @@ $(DefaultLanguage) + + 15.0 + + Properties My Project diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets index d74f43b..f7e475b 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets @@ -8,11 +8,6 @@ true - - <_SdkVisualStudioVersion>$(VisualStudioVersion) - <_SdkVisualStudioVersion Condition="'$(_SdkVisualStudioVersion)' == '' OR '$(_SdkVisualStudioVersion)' < '14.0'">15.0 - - From 12b130d2cce0a83c8c7f6e863bcc75fd0c3e64f1 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Wed, 20 Jun 2018 12:53:09 +0530 Subject: [PATCH 03/18] Privatized ('_' prefix) internal variable names So that we won't clash with other names that matches these! --- .../Build/LanguageTargets/CheckMissing.targets | 2 +- .../Build/MSBuild.NET.Workarounds.props | 6 +++--- .../Build/MSBuild.NET.Workarounds.targets | 14 +++++++------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets index 9b51fd7..d3a1869 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets @@ -12,7 +12,7 @@ - + diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props index 19660f5..4bc3e2b 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props @@ -10,13 +10,13 @@ - _[a-z0-9]{8}_wpftmp - true + <_GeneratedProjectSuffixPattern>_[a-z0-9]{8}_wpftmp + true <_OriginalProjectName>$(_TargetAssemblyProjectName) - <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$([System.Text.RegularExpressions.Regex]::Replace('$(MSBuildProjectName)', '$(GeneratedProjectSuffixPattern)', '')) + <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$([System.Text.RegularExpressions.Regex]::Replace('$(MSBuildProjectName)', '$(_GeneratedProjectSuffixPattern)', '')) <_OriginalProjectFile>$(_OriginalProjectName)$(MSBuildProjectExtension) <_OriginalProjectExtensionsPath Condition="$(MSBuildProjectExtensionsPath.Contains('$(MSBuildProjectName)'))">$(MSBuildProjectExtensionsPath.Replace('$(MSBuildProjectName)', '$(_OriginalProjectName)')) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets index 283d026..3cb7e64 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets @@ -16,10 +16,10 @@ --> + Condition="('$(IsGeneratedProject)' == 'true') AND $([System.Text.RegularExpressions.Regex]::IsMatch('$(RootNamespace)', '$(_GeneratedProjectSuffixPattern)'))"> <_RootNamespaceInGeneratedProject>$(RootNamespace) - $([System.Text.RegularExpressions.Regex]::Replace('$(_RootNamespaceInGeneratedProject)', '$(GeneratedProjectSuffixPattern)', '')) + $([System.Text.RegularExpressions.Regex]::Replace('$(_RootNamespaceInGeneratedProject)', '$(_GeneratedProjectSuffixPattern)', '')) @@ -44,7 +44,7 @@ - @@ -54,7 +54,7 @@ - $(TargetsForTfmSpecificContentInPackage);IncludeWindowsLibraryLayoutItems + $(TargetsForTfmSpecificContentInPackage);_IncludeWindowsLibraryLayoutItems - @@ -87,12 +87,12 @@ - WarnWhenUsingOldSdk;$(PackDependsOn) + _WarnWhenUsingOldSdk;$(PackDependsOn) true - + From d95f8f7d1e840b147ea9054889a107138ad670a1 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Wed, 20 Jun 2018 12:55:21 +0530 Subject: [PATCH 04/18] clean up Inference targets upstream patch for Identifier check comments clean up --- .../Build/MSBuild.NET.Inference.targets | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Inference.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Inference.targets index e75684f..b53f65f 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Inference.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Inference.targets @@ -5,19 +5,21 @@ - + $(TargetFramework.ToLowerInvariant()) net40-client + net35-cf + netmf44 net45 - wp8 wpa81 win8 + wp8 sl5 - + .NETFramework .NETStandard .NETCoreApp From e34ebdeab8525009e2b6374369db1733cfa8d198 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Wed, 20 Jun 2018 12:57:36 +0530 Subject: [PATCH 05/18] Update Desktop Items upstream patch: fixed EmbeddedResource Added section comments --- .../DefaultItems/Platforms/Desktop.props | 12 +++++++++--- .../DefaultItems/Platforms/Desktop.targets | 11 +++++++---- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props index 1338c5f..3dfd426 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props @@ -4,6 +4,8 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) + + MSBuild:Compile @@ -32,19 +34,23 @@ $([MSBuild]::ValueOrDefault('%(Filename)', '').Replace('$(DefaultDesignerFileSuffix)', '$(DefaultLanguageSourceExtension)')) + + + - $([System.Text.RegularExpressions.Regex]::Replace('%(FileName)', '$(LangIdRegEx)|\$(DefaultDesignerFileSuffix)', '%(DefaultLanguageSourceExtension)')) + %(Filename)$(DefaultLanguageSourceExtension) - + + diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets index 8da4405..e364f94 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets @@ -35,29 +35,32 @@ PublicSettingsSingleFileGenerator + + true $(EnableDefaultWpfItems) true + + true true false - - - {94E38DFF-614B-4CBD-B67C-F211BB35CE8B} + + true true - + \ No newline at end of file From e806c09b6ea21f53bfb8212dce9b4214b0b3f863 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Wed, 20 Jun 2018 18:42:33 +0530 Subject: [PATCH 06/18] Added WPF 'tmp_proj' workaround back Some people really need it!!! And no, they don't want to update to net472 --- Directory.Build.rsp | 2 +- .../Build/MSBuild.NET.Extras.Sdk.props | 2 +- .../Build/MSBuild.NET.Workarounds.props | 28 +++++++++++++++---- .../Build/MSBuild.NET.Workarounds.targets | 5 ++-- .../DefaultItems/Platforms/Xaml.props | 3 ++ 5 files changed, 31 insertions(+), 9 deletions(-) diff --git a/Directory.Build.rsp b/Directory.Build.rsp index ade9e42..d71a0fc 100644 --- a/Directory.Build.rsp +++ b/Directory.Build.rsp @@ -1,6 +1,6 @@ /MaxCPUCount /BinaryLogger /DetailedSummary -/Verbosity:minimal +/Verbosity:normal /NodeReuse:false /Restore \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props index 2d8a3a5..bd0b68e 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.props @@ -27,7 +27,7 @@ - + <_LanguageSourceName>Common diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props index 4bc3e2b..cf2abdd 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props @@ -8,18 +8,36 @@ true - <_GeneratedProjectSuffixPattern>_[a-z0-9]{8}_wpftmp - true + + + + + true + <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$(AssemblyName) + <_LanguageSourceName Condition="Exists('$(MSBuildProjectDirectory)\$(_OriginalProjectName).csproj')">CSharp + <_LanguageSourceName Condition="Exists('$(MSBuildProjectDirectory)\$(_OriginalProjectName).vbproj')">VisualBasic + + + + + + + true + <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$(_TargetAssemblyProjectName) + <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$([System.Text.RegularExpressions.Regex]::Replace('$(MSBuildProjectName)', '$(_GeneratedProjectSuffixPattern)', '')) + + + + + + - <_OriginalProjectName>$(_TargetAssemblyProjectName) - <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$([System.Text.RegularExpressions.Regex]::Replace('$(MSBuildProjectName)', '$(_GeneratedProjectSuffixPattern)', '')) <_OriginalProjectFile>$(_OriginalProjectName)$(MSBuildProjectExtension) <_OriginalProjectExtensionsPath Condition="$(MSBuildProjectExtensionsPath.Contains('$(MSBuildProjectName)'))">$(MSBuildProjectExtensionsPath.Replace('$(MSBuildProjectName)', '$(_OriginalProjectName)')) - $(_OriginalProjectExtensionsPath) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets index 3cb7e64..76fbda2 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets @@ -16,7 +16,7 @@ --> + Condition="'$(IsGeneratedProject)' == 'true' AND $([System.Text.RegularExpressions.Regex]::IsMatch('$(RootNamespace)', '$(_GeneratedProjectSuffixPattern)'))"> <_RootNamespaceInGeneratedProject>$(RootNamespace) $([System.Text.RegularExpressions.Regex]::Replace('$(_RootNamespaceInGeneratedProject)', '$(_GeneratedProjectSuffixPattern)', '')) @@ -38,9 +38,10 @@ --> + Condition="'@(ApplicationDefinition)' != '' OR '@(Page)' != '' OR '@(Resource)' != ''"> false + true diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props index ce1905b..064c43d 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props @@ -41,6 +41,9 @@ $(XamlCodeGeneratorTool) + + + %(Filename) From 6297fae7f3d55f390d14dabd7f91c0c1bc92be30 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Wed, 20 Jun 2018 20:10:20 +0530 Subject: [PATCH 07/18] Updated VS Project System support upstream patches: Added Nesting and Dependent files support Workaround for CodeAnalysis, Intellisense, etc... --- .../MSBuild.NET.ProjectSystem.props | 26 ++++++++++++++---- .../MSBuild.NET.ProjectSystem.targets | 11 ++++++++ .../Rules/Wpf.ProjectItemsSchema.xml | 13 --------- .../Rules/Xaml.ProjectItemsSchema.xml | 27 +++++++++++++++++++ 4 files changed, 59 insertions(+), 18 deletions(-) create mode 100644 Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.targets delete mode 100644 Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Wpf.ProjectItemsSchema.xml create mode 100644 Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props b/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props index fda5f76..d406a30 100644 --- a/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props +++ b/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props @@ -4,19 +4,35 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) - - + + + + + + + + Project - + File;BrowseObject - + File;BrowseObject - + File;BrowseObject + + + + + + + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.targets b/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.targets new file mode 100644 index 0000000..ae19534 --- /dev/null +++ b/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.targets @@ -0,0 +1,11 @@ + + + + $(MSBuildAllProjects);$(MSBuildThisFileFullPath) + + + + <_SdkProjectSystemRulesDirectory>$(MSBuildThisFileDirectory)Rules\ + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Wpf.ProjectItemsSchema.xml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Wpf.ProjectItemsSchema.xml deleted file mode 100644 index eb4002f..0000000 --- a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Wpf.ProjectItemsSchema.xml +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - - - - - - - - \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml new file mode 100644 index 0000000..a8751e4 --- /dev/null +++ b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml @@ -0,0 +1,27 @@ + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file From c36d063f5df6510186486ed75f1b053be61683df Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Thu, 21 Jun 2018 20:42:24 +0530 Subject: [PATCH 08/18] Build env updates Move packaging related props --- Source/Directory.Build.props | 7 +----- .../MSBuild.Sdk.Extras.csproj | 7 +----- Tools/MSBuild.Packaging.props | 15 +++++++++++++ Tools/MSBuild.Packaging.targets | 22 ++++++++++++++----- 4 files changed, 33 insertions(+), 18 deletions(-) create mode 100644 Tools/MSBuild.Packaging.props diff --git a/Source/Directory.Build.props b/Source/Directory.Build.props index 340f460..a7fa857 100644 --- a/Source/Directory.Build.props +++ b/Source/Directory.Build.props @@ -12,12 +12,7 @@ $(BuildToolsPath)MSBuild.OutputPaths.targets - - true - false - true - true - + Oren Novotny diff --git a/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj b/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj index 8216249..03d861e 100644 --- a/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj +++ b/Source/MSBuild.Sdk.Extras/MSBuild.Sdk.Extras.csproj @@ -2,6 +2,7 @@ netstandard1.0 + true @@ -11,12 +12,6 @@ An MSBuild SDK package for SDK-style .NET projects that has additional properties and targets which extends `Microsoft.NET.Sdk`. - - - - - - \ No newline at end of file diff --git a/Tools/MSBuild.Packaging.props b/Tools/MSBuild.Packaging.props new file mode 100644 index 0000000..e2ae1f9 --- /dev/null +++ b/Tools/MSBuild.Packaging.props @@ -0,0 +1,15 @@ + + + + + Full + + + + + + + + + + \ No newline at end of file diff --git a/Tools/MSBuild.Packaging.targets b/Tools/MSBuild.Packaging.targets index 9377769..d7f618c 100644 --- a/Tools/MSBuild.Packaging.targets +++ b/Tools/MSBuild.Packaging.targets @@ -9,23 +9,33 @@ true - + + true + + + + true + $(DefaultItemExcludes);$(DefaultExcludesInProjectFolder) + $(DefaultContentItemExcludes);**\*$(DefaultLanguageSourceExtension);**\*.resx + + + + true + false + true false false false - **\*$(DefaultLanguageSourceExtension) true - - Full - + - + BuildOnlySettings; PrepareForBuild; From 324e16c2f2cd506bd7d958e53483b9cca6460067 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Fri, 22 Jun 2018 02:15:26 +0530 Subject: [PATCH 09/18] WPF/WFF tmp ptoject workaround updates Use '_TargetAssemblyProjectName' Generalize Fixup target Drop '_Sdk' for user facing properties. --- .../Build/MSBuild.NET.Workarounds.props | 10 ++--- .../Build/MSBuild.NET.Workarounds.targets | 43 ++++++++++++------- .../MSBuild.NET.ProjectSystem.props | 8 ++-- 3 files changed, 37 insertions(+), 24 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props index cf2abdd..dfe3244 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props @@ -23,19 +23,19 @@ - - + + true <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$(_TargetAssemblyProjectName) - <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$([System.Text.RegularExpressions.Regex]::Replace('$(MSBuildProjectName)', '$(_GeneratedProjectSuffixPattern)', '')) + <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$([System.Text.RegularExpressions.Regex]::Replace('$(MSBuildProjectName)', '$(_GeneratedProjectSuffixPattern)%24', '')) - + <_OriginalProjectFile>$(_OriginalProjectName)$(MSBuildProjectExtension) <_OriginalProjectExtensionsPath Condition="$(MSBuildProjectExtensionsPath.Contains('$(MSBuildProjectName)'))">$(MSBuildProjectExtensionsPath.Replace('$(MSBuildProjectName)', '$(_OriginalProjectName)')) $(_OriginalProjectExtensionsPath) @@ -43,7 +43,7 @@ diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets index 76fbda2..3f82da8 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets @@ -11,22 +11,34 @@ - - + Condition="'$(IsGeneratedProject)' == 'true' AND '$(DisableFixupPropertiesWithGeneratedSuffix)' != 'true'"> + + <_RootNamespaceInGeneratedProject>$(RootNamespace) - $([System.Text.RegularExpressions.Regex]::Replace('$(_RootNamespaceInGeneratedProject)', '$(_GeneratedProjectSuffixPattern)', '')) + + + + $(_OriginalProjectName) + $(_RootNamespaceInGeneratedProject.Replace('$(MSBuildProjectName)', '$(_OriginalProjectName)')) + + + $([System.Text.RegularExpressions.Regex]::Replace('$(_RootNamespaceInGeneratedProject)', '$(_GeneratedProjectSuffixPattern)', '')) + $([System.Text.RegularExpressions.Regex]::Replace('$(_RootNamespaceInGeneratedProject)', $(_GeneratedProjectSuffixPattern.Replace('_', '.')), '')) - + + + @@ -45,19 +57,20 @@ + + + + $(TargetsForTfmSpecificContentInPackage);_IncludeWindowsLibraryLayoutItems + + + DependsOnTargets="PrepareLibraryLayout" + Condition="'$(GenerateLibraryLayout)' == 'true' AND '$(SDKIdentifier)' == 'Windows'"> - - - $(TargetsForTfmSpecificContentInPackage);_IncludeWindowsLibraryLayoutItems - - - + From 5cb746f953ea8a3a15e07c87d106b9095f97c8bb Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sat, 23 Jun 2018 18:18:01 +0530 Subject: [PATCH 10/18] Update Project System Support Take 2: DynamicDependentFile not working, keep static evaluation for now! Include missing ProjectSystem.targets file --- .../Build/MSBuild.NET.Extras.Sdk.targets | 1 + .../DefaultItems/Platforms/Desktop.targets | 4 +- .../MSBuild.NET.ProjectSystem.props | 15 +++--- ...inition.xml => ApplicationDefinition.xaml} | 0 .../Rules/CSharp.ProjectItemsSchema.xaml | 14 +++++ .../Rules/{Page.xml => Page.xaml} | 0 .../Rules/ProjectItemsSchema.xaml | 54 +++++++++++++++++++ .../Rules/{Resource.xml => Resource.xaml} | 0 .../Rules/VisualBasic.ProjectItemsSchema.xaml | 22 ++++++++ .../Rules/Xaml.ProjectItemsSchema.xml | 27 ---------- 10 files changed, 102 insertions(+), 35 deletions(-) rename Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/{ApplicationDefinition.xml => ApplicationDefinition.xaml} (100%) create mode 100644 Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/CSharp.ProjectItemsSchema.xaml rename Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/{Page.xml => Page.xaml} (100%) create mode 100644 Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ProjectItemsSchema.xaml rename Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/{Resource.xml => Resource.xaml} (100%) create mode 100644 Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/VisualBasic.ProjectItemsSchema.xaml delete mode 100644 Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets index f7e475b..49cd001 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets @@ -20,5 +20,6 @@ + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets index e364f94..7d85509 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.targets @@ -21,8 +21,8 @@ - $(AppDesignerFolder)\app.manifest - app.manifest + $(AppDesignerFolder)\App.manifest + App.manifest diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props b/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props index 0e34c4e..a749dce 100644 --- a/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props +++ b/Source/MSBuild.Sdk.Extras/ProjectSystem/MSBuild.NET.ProjectSystem.props @@ -5,22 +5,25 @@ - - + + - + + Project + + Project - + File;BrowseObject - + File;BrowseObject - + File;BrowseObject diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ApplicationDefinition.xml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ApplicationDefinition.xaml similarity index 100% rename from Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ApplicationDefinition.xml rename to Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ApplicationDefinition.xaml diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/CSharp.ProjectItemsSchema.xaml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/CSharp.ProjectItemsSchema.xaml new file mode 100644 index 0000000..1053f3b --- /dev/null +++ b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/CSharp.ProjectItemsSchema.xaml @@ -0,0 +1,14 @@ + + + + + + + + + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Page.xml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Page.xaml similarity index 100% rename from Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Page.xml rename to Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Page.xaml diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ProjectItemsSchema.xaml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ProjectItemsSchema.xaml new file mode 100644 index 0000000..e88c672 --- /dev/null +++ b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/ProjectItemsSchema.xaml @@ -0,0 +1,54 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Resource.xml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Resource.xaml similarity index 100% rename from Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Resource.xml rename to Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Resource.xaml diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/VisualBasic.ProjectItemsSchema.xaml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/VisualBasic.ProjectItemsSchema.xaml new file mode 100644 index 0000000..5adc8b5 --- /dev/null +++ b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/VisualBasic.ProjectItemsSchema.xaml @@ -0,0 +1,22 @@ + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml b/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml deleted file mode 100644 index a8751e4..0000000 --- a/Source/MSBuild.Sdk.Extras/ProjectSystem/Rules/Xaml.ProjectItemsSchema.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file From 40c05d64fc42ca8bb10130924c6f89a078c49163 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sat, 23 Jun 2018 18:32:34 +0530 Subject: [PATCH 11/18] Prefix '_' to 'IsGeneratedProject' property Since, IsGeneratedProject is not supposed to be a user facing property! --- Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props | 4 ++-- .../MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props index dfe3244..6027881 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.props @@ -16,7 +16,7 @@ - true + <_IsGeneratedProject>true <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$(AssemblyName) <_LanguageSourceName Condition="Exists('$(MSBuildProjectDirectory)\$(_OriginalProjectName).csproj')">CSharp <_LanguageSourceName Condition="Exists('$(MSBuildProjectDirectory)\$(_OriginalProjectName).vbproj')">VisualBasic @@ -26,7 +26,7 @@ - true + <_IsGeneratedProject>true <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$(_TargetAssemblyProjectName) <_OriginalProjectName Condition="'$(_OriginalProjectName)' == ''">$([System.Text.RegularExpressions.Regex]::Replace('$(MSBuildProjectName)', '$(_GeneratedProjectSuffixPattern)%24', '')) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets index 3f82da8..de444c4 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets @@ -6,7 +6,7 @@ - false + false true @@ -16,7 +16,7 @@ --> + Condition="'$(_IsGeneratedProject)' == 'true' AND '$(DisableFixupPropertiesWithGeneratedSuffix)' != 'true'"> <_RootNamespaceInGeneratedProject>$(RootNamespace) From bd5a49cf4c6149dc4fb11ef7385b43557bb995ed Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sun, 24 Jun 2018 13:21:02 +0530 Subject: [PATCH 12/18] Finalize LanguageTargets Remove Test Hooks Give a common property --- .../LanguageTargets/CheckMissing.targets | 3 +-- .../Build/LanguageTargets/Desktop.targets | 10 +++++----- .../Build/LanguageTargets/Portable.targets | 10 +++++----- .../Build/LanguageTargets/Silverlight.targets | 12 ++++++++--- .../Build/LanguageTargets/Windows.targets | 9 ++++++--- .../LanguageTargets/WindowsPhone.targets | 20 +++++++++++-------- .../Build/LanguageTargets/Xamarin.targets | 8 ++++---- .../Build/MSBuild.NET.Platforms.targets | 13 ++++++++---- 8 files changed, 51 insertions(+), 34 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets index d3a1869..014e93e 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/CheckMissing.targets @@ -5,8 +5,7 @@ - <_SdkFallbackLanguageTargets Condition="'$(IsMultiTargetingBuild)' != 'true'">$(MSBuildToolsPath)\Microsoft.Common.CurrentVersion.targets - <_SdkFallbackLanguageTargets Condition="'$(IsMultiTargetingBuild)' == 'true'">$(MSBuildToolsPath)\Microsoft.Common.CrossTargeting.targets + <_SdkFallbackLanguageTargets>$(MSBuildToolsPath)\Microsoft.Common.targets diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets index 66bd612..9f303b2 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets @@ -8,16 +8,16 @@ Only MSBuild Full Framework build includes WPF targets which redirects to MSBuildFrameworkToolsPath. So to have WPF support, we need to use the targets in the MSBuild Full Framework build path. --> - - <_SdkDesktopTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\$(VisualStudioVersion)\Bin\Microsoft.$(_LanguageSourceName).targets - <_SdkDesktopTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets + + <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\$(VisualStudioVersion)\Bin\Microsoft.$(_LanguageSourceName).targets + <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets - <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkDesktopTargets)')">true + <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkLanguageTargets)')">true - + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets index c1a854d..977f4d3 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Portable.targets @@ -4,16 +4,16 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) - - <_SdkPortableTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\Portable\$(TargetFrameworkVersion)\Microsoft.Portable.$(_LanguageSourceName).targets - <_SdkPortableTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.Portable.FSharp.Targets + + <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\Portable\$(TargetFrameworkVersion)\Microsoft.Portable.$(_LanguageSourceName).targets + <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.Portable.FSharp.Targets - <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkPortableTargets)')">true + <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkLanguageTargets)')">true - + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Silverlight.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Silverlight.targets index 833dde4..5f382b3 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Silverlight.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Silverlight.targets @@ -7,11 +7,17 @@ <_SdkMSBuildExtensionsPath>$(MSBuildProgramFiles32)\MSBuild - <_SdkSilverlightTargets Condition="'$(_SdkSilverlightTargets)' == ''">$(_SdkMSBuildExtensionsPath)\Microsoft\Silverlight\$(SilverlightVersion)\Microsoft.Silverlight.$(_LanguageSourceName).targets - <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkSilverlightTargets)')">true - + + <_SdkLanguageTargets>$(_SdkMSBuildExtensionsPath)\Microsoft\Silverlight\$(SilverlightVersion)\Microsoft.Silverlight.$(_LanguageSourceName).targets + + + + <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkLanguageTargets)')">true + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets index 22f3152..f0d6afd 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Windows.targets @@ -5,11 +5,14 @@ - <_SdkWindowsTargets Condition="'$(_SdkWindowsTargets)' == ''">$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.$(_LanguageSourceName).targets - <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkWindowsTargets)')">true + <_SdkLanguageTargets>$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.$(_LanguageSourceName).targets - + + <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkLanguageTargets)')">true + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/WindowsPhone.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/WindowsPhone.targets index 0686192..636e1b3 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/WindowsPhone.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/WindowsPhone.targets @@ -7,15 +7,19 @@ <_SdkMSBuildExtensionsPath>$(MSBuildProgramFiles32)\MSBuild - <_SdkWindowsPhoneOverridesTargets Condition="'$(_SdkWindowsPhoneOverridesTargets)' == ''">$(_SdkMSBuildExtensionsPath)\Microsoft\$(TargetFrameworkIdentifier)\$(TargetFrameworkVersion)\Microsoft.$(TargetFrameworkIdentifier).$(TargetFrameworkVersion).Overrides.targets - <_SdkWindowsPhoneTargets Condition="'$(_SdkWindowsPhoneTargets)' == ''">$(_SdkMSBuildExtensionsPath)\Microsoft\$(TargetFrameworkIdentifier)\$(TargetFrameworkVersion)\Microsoft.$(TargetFrameworkIdentifier).$(_LanguageSourceName).targets - <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkWindowsPhoneTargets)')">true - - - - - + + <_SdkLanguageTargets>$(_SdkMSBuildExtensionsPath)\Microsoft\$(TargetFrameworkIdentifier)\$(TargetFrameworkVersion)\Microsoft.$(TargetFrameworkIdentifier).$(_LanguageSourceName).targets + <_SdkLanguageOverridesTargets>$(_SdkMSBuildExtensionsPath)\Microsoft\$(TargetFrameworkIdentifier)\$(TargetFrameworkVersion)\Microsoft.$(TargetFrameworkIdentifier).$(TargetFrameworkVersion).Overrides.targets + + + + <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkLanguageTargets)')">true + + + + + \ No newline at end of file diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets index 7dcf322..27491b1 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets @@ -20,15 +20,15 @@ <_SdkTargetsImportType Condition="'$(IsApplePlatform)' == 'true'">ObjCBinding.$(_LanguageSourceName) - - <_SdkXamarinPlatformTargets>$(MSBuildExtensionsPath)\Xamarin\$(_SdkTargetPlatformName)\Xamarin.$(_SdkTargetPlatformName).$(_SdkTargetsImportType).targets + + <_SdkLanguageTargets>$(MSBuildExtensionsPath)\Xamarin\$(_SdkTargetPlatformName)\Xamarin.$(_SdkTargetPlatformName).$(_SdkTargetsImportType).targets - <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkXamarinPlatformTargets)')">true + <_SdkLanguageTargetsMissing Condition="!Exists('$(_SdkLanguageTargets)')">true - + diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Platforms.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Platforms.targets index 1bb23e4..985bcae 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Platforms.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Platforms.targets @@ -11,10 +11,11 @@ <_SdkPlatformName Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">Desktop <_SdkPlatformName Condition="$(TargetFrameworkIdentifier.StartsWith('Xamarin'))">Xamarin <_SdkPlatformName Condition="'$(TargetFrameworkIdentifier)' == 'MonoAndroid' OR '$(TargetFrameworkIdentifier)' == 'MonoTouch' OR '$(TargetFrameworkIdentifier)' == 'MonoMac'">Xamarin + - <_SdkPlatformTargets>$(MSBuildThisFileDirectory)Platforms\$(_SdkPlatformName).targets - <_SdkLanguageTargets>$(MSBuildThisFileDirectory)LanguageTargets\$(_SdkPlatformName).targets - $(_SdkLanguageTargets) + + $(MSBuildThisFileDirectory)LanguageTargets\$(_SdkPlatformName).targets + @@ -23,7 +24,11 @@ $(TargetFramework.Replace('.','_').Replace('-','_').ToUpperInvariant()) - + + $(MSBuildThisFileDirectory)Platforms\$(_SdkPlatformName).targets + + + From 7e709797346a9cea96a60bdd0da76c486d86911d Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sun, 24 Jun 2018 13:37:05 +0530 Subject: [PATCH 13/18] Make 'MSBuild:Compile' into a property just like every other custom tool so that we can keep track of it! --- .../MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.props | 2 +- .../DefaultItems/Platforms/Common.targets | 1 + .../DefaultItems/Platforms/Desktop.VisualBasic.props | 2 +- .../MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props | 2 +- Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props | 6 +++--- .../MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.targets | 4 ++-- .../ProjectSystem/Rules/ProjectItemsSchema.xaml | 4 ---- 7 files changed, 9 insertions(+), 12 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.props b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.props index 4b45eb8..8ef475a 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.props +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.props @@ -16,7 +16,7 @@ Designer - MSBuild:Compile + $(DefaultGeneratorTool) diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.targets b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.targets index 41aa9ef..0672b92 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.targets +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Common.targets @@ -5,6 +5,7 @@ + MSBuild:Compile .Designer diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.VisualBasic.props b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.VisualBasic.props index a2154ed..1bad64e 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.VisualBasic.props +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.VisualBasic.props @@ -12,7 +12,7 @@ - MSBuild:Compile + $(DefaultGeneratorTool) diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props index 3dfd426..289bd8f 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Desktop.props @@ -8,7 +8,7 @@ - MSBuild:Compile + $(DefaultGeneratorTool) diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props index 064c43d..448e243 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.props @@ -7,15 +7,15 @@ Designer - MSBuild:Compile + $(DefaultGeneratorTool) Designer - MSBuild:Compile + $(DefaultGeneratorTool) Designer - MSBuild:Compile + $(DefaultGeneratorTool) diff --git a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.targets b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.targets index b6d1346..8010322 100644 --- a/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.targets +++ b/Source/MSBuild.Sdk.Extras/DefaultItems/Platforms/Xaml.targets @@ -26,11 +26,11 @@ - MSBuild:Compile + $(DefaultGeneratorTool) - MSBuild:XamlIntelliSenseFileGenerator + XamlIntelliSenseFileGenerator - + diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets index 9f303b2..c44ff31 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Desktop.targets @@ -4,13 +4,20 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) - + + $(ToolDepsJsonGeneratorProject.TrimEnd('GenerateDeps\GenerateDeps.proj')) + $(_NugetFallbackFolder.TrimEnd('..\..\..\..\NuGetFallbackFolder')) + $(NETCoreSdkBundledVersionsProps.TrimEnd('..\..\..\Microsoft.NETCoreSdk.BundledVersions.props')) + + + + <_FSharpTargetsPath>$(MicrosoftNETSdkTargetsPath)Microsoft.NET.Sdk.FSharpTargetsShim.targets + <_FSharpTargetsPath Condition="!Exists('$(_FSharpTargetsPath)')">$(MicrosoftNETSdkTargetsPath)Microsoft.NET.Sdk.FSharp.targets + + - <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildExtensionsPath)\$(VisualStudioVersion)\Bin\Microsoft.$(_LanguageSourceName).targets - <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets + <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' != 'FSharp'">$(MSBuildToolsPath)\Microsoft.$(_LanguageSourceName).targets + <_SdkLanguageTargets Condition="'$(_LanguageSourceName)' == 'FSharp'">$(_FSharpTargetsPath) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets index de444c4..5dd2907 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets @@ -4,6 +4,26 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) + + + <_IgnoreMSBuildCoreWarning>true + <_IgnoreMSBuildCoreWarning Condition="'$(EnableWpfProjectSetup)' == 'true'">false + <_IgnoreMSBuildCoreWarning Condition="'$(_SdkPlatformName)' == 'Silverlight'">false + <_IgnoreMSBuildCoreWarning Condition="$(_SdkPlatformName.StartsWith('Windows'))">false + + + + + + + <_IgnoreMissingLanguageTargetsError>$(_SdkLanguageTargetsMissing) + + + + + false @@ -99,15 +119,15 @@ - + _WarnWhenUsingOldSdk;$(PackDependsOn) - true + true - - + + \ No newline at end of file From 70001b8a0875a3d003d0019913798b07041c16e2 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sun, 24 Jun 2018 18:41:46 +0530 Subject: [PATCH 15/18] Compat with oboslete properties Issue a warning when using those properties --- .../Build/MSBuild.NET.Extras.Sdk.targets | 2 + .../Build/MSBuild.Sdk.ExtrasShim.targets | 49 +++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets index 49cd001..453f9c9 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Extras.Sdk.targets @@ -4,6 +4,8 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) + + true diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets new file mode 100644 index 0000000..f45c412 --- /dev/null +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets @@ -0,0 +1,49 @@ + + + + false + true + + + + $(SuppressWarnIfOldSdkPack) + $(ExtrasSkipLibraryLayout) + $(_SdkSetAndroidResgenFile) + + + + <_ImplicitPlatformPackageVersion Condition="$(TargetFramework.StartsWith('uap'))">$(ExtrasUwpMetaPackageVersion) + $(ExtrasImplicitPlatformPackageDisabled) + + + + + + + + + + + <_SdkObsoleteProperty Include="ExtrasSkipLibraryLayout" Replacement="SkipWindowsLibraryLayout" Condition="'$(ExtrasSkipLibraryLayout)' != ''"/> + <_SdkObsoleteProperty Include="_SdkSetAndroidResgenFile" Replacement="IncludeAndroidResgenFile" Condition="'$(_SdkSetAndroidResgenFile)' != ''"/> + <_SdkObsoleteProperty Include="SuppressWarnIfOldSdkPack" Replacement="IgnoreOldSdkWarning" Condition="'$(SuppressWarnIfOldSdkPack)' != ''"/> + <_SdkObsoleteProperty Include="ExtrasUwpMetaPackageVersion" Replacement="_ImplicitPlatformPackageVersion (with TargetFramework condition)" Condition="'$(ExtrasUwpMetaPackageVersion)' != ''"/> + <_SdkObsoleteProperty Include="ExtrasImplicitPlatformPackageDisabled" Replacement="DisableImplicitFrameworkReferences (with TargetFramework condition)" Condition="'$(ExtrasImplicitPlatformPackageDisabled)' != ''"/> + <_SdkObsoleteProperty Include="ExtrasImplicitPlatformPackageIsPrivate" Condition="'$(ExtrasImplicitPlatformPackageIsPrivate)' != ''"/> + <_SdkObsoleteProperty Include="EmbeddedResourceGeneratorVisibilityIsInternal" Replacement="EmbeddedResourceGeneratedCodeIsPublic" Condition="'$(EmbeddedResourceGeneratorVisibilityIsInternal)' != ''"/> + + + + + + + + + + \ No newline at end of file From 63594512d1006824651a6ce80a162dfad893e204 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sun, 24 Jun 2018 19:24:26 +0530 Subject: [PATCH 16/18] Add docs for using the SDK For now it only includes migration path from old SDK version. --- Docs/Using-Extras-SDK.md | 64 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Docs/Using-Extras-SDK.md diff --git a/Docs/Using-Extras-SDK.md b/Docs/Using-Extras-SDK.md new file mode 100644 index 0000000..2afe373 --- /dev/null +++ b/Docs/Using-Extras-SDK.md @@ -0,0 +1,64 @@ +# Using the Extras Sdk + +## Migrate from previous versions + +If you're using v1.6+ of the Extras SDK, then you would know that few properties have been changed, and the help is provided as a warning to use the new property names. + +If you're not using the new version, and/or wish to migrate your build system to support this version, here are the instructions to do just that: + +0. BACK UP! BACK UP! (if you're not using version control) + +1. First remove any workarounds (check the closed issues first) that you've applied using the previous Extras SDK version. + +2. If you're using Visual Studio IDE v15.6+ (if you can update, then update) and use SDK style. + +Your project diff: + +```diff +- ++ + + + net46;uwp10.0;tizen40 + + + +- + + + +- + + +``` + +```diff +- PackageReference style ++ SDK style +``` + +More info: [ReadMe](../README.md) + +3. Remove any UWP/Tizen package referneces as they are implicitly included if you're using SDK style. + +4. Rename these properties to the new ones + +### User facing properties + +| OLD Property | NEW Property/Behaviour | +| --- | ---- | +| `ExtrasSkipLibraryLayout` | `SkipWindowsLibraryLayout` | +| `_SdkSetAndroidResgenFile` | `IncludeAndroidResgenFile` | +| `SuppressWarnIfOldSdkPack` | `IgnoreOldSdkWarning` | +| `ExtrasUwpMetaPackageVersion` | `_ImplicitPlatformPackageVersion` + `TargetFramework` condition | +| `ExtrasImplicitPlatformPackageDisabled` | `DisableImplicitFrameworkReferences` + `TargetFramework` condition | +| `ExtrasImplicitPlatformPackageIsPrivate` | Auto set for library like items | +| `EmbeddedResourceGeneratorVisibilityIsInternal` | opposite of `EmbeddedResourceGeneratedCodeIsPublic` | + +5. If you're using it for WinForms/WPF, you can set `EnableWpfProjectSetup`/`EnableWinFormsProjectSetup` to `true` to include required references and default items. + +6. That's it you're done! If you find any issues during build, check with the [Templates/TestProjects](../TestProjects) included and create an issue if that doesn't help. + +## Customizing your Build setup + +TBD \ No newline at end of file From 0edd8416d662108c1cc1fe21bae2d7cdf7bd5991 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sun, 24 Jun 2018 19:57:52 +0530 Subject: [PATCH 17/18] Update placeholder URL Will work once the PR is merged --- Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets index f45c412..3e2454b 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.Sdk.ExtrasShim.targets @@ -36,7 +36,7 @@ <_SdkObsoleteProperty Include="EmbeddedResourceGeneratorVisibilityIsInternal" Replacement="EmbeddedResourceGeneratedCodeIsPublic" Condition="'$(EmbeddedResourceGeneratorVisibilityIsInternal)' != ''"/> - Date: Sun, 24 Jun 2018 20:13:06 +0530 Subject: [PATCH 18/18] Fix condition on using MSBuild Core target Just a little fix --- Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets index 5dd2907..061dec6 100644 --- a/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets +++ b/Source/MSBuild.Sdk.Extras/Build/MSBuild.NET.Workarounds.targets @@ -15,7 +15,7 @@ + Condition="'$(MSBuildRuntimeType)' == 'Core' AND '$(_IgnoreMSBuildCoreWarning)' != 'true'"> <_IgnoreMissingLanguageTargetsError>$(_SdkLanguageTargetsMissing)