From 7dfe195f6e424ee07f6157181b1ecc1e39f2f619 Mon Sep 17 00:00:00 2001 From: Sokratis Vidros Date: Tue, 28 May 2024 16:25:41 +0300 Subject: [PATCH] fix(api): Remove faker (#5645) Faker is used from API only for testing purposes. It causes issues with dockerization. --- apps/api/package.json | 1 - .../src/app/testing/usecases/seed-data/seed-data.usecase.ts | 5 ++--- pnpm-lock.yaml | 5 ++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/apps/api/package.json b/apps/api/package.json index 25fc7868d97..14064fe29ae 100644 --- a/apps/api/package.json +++ b/apps/api/package.json @@ -93,7 +93,6 @@ "uuid": "^8.3.2" }, "devDependencies": { - "@faker-js/faker": "^6.0.0", "@nestjs/cli": "^10.1.16", "@nestjs/schematics": "^10.0.2", "@nestjs/testing": "^10.2.2", diff --git a/apps/api/src/app/testing/usecases/seed-data/seed-data.usecase.ts b/apps/api/src/app/testing/usecases/seed-data/seed-data.usecase.ts index 891ffe7f277..7b21113b534 100644 --- a/apps/api/src/app/testing/usecases/seed-data/seed-data.usecase.ts +++ b/apps/api/src/app/testing/usecases/seed-data/seed-data.usecase.ts @@ -1,5 +1,4 @@ import { Injectable } from '@nestjs/common'; -import { faker } from '@faker-js/faker'; import { AuthService } from '@novu/application-generic'; @@ -15,8 +14,8 @@ export class SeedData { async execute(command: SeedDataCommand) { const data = { email: 'test-user-1@example.com', - firstName: faker.name.firstName(), - lastName: faker.name.lastName(), + firstName: `John-${new Date().toISOString()}`, + lastName: `Doe-${new Date().toISOString()}`, password: '123qwe!@#', organizationName: 'Test Organization', }; diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 5b5519a6817..0c6c6b05217 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -529,9 +529,6 @@ importers: specifier: workspace:* version: link:../../enterprise/packages/translation devDependencies: - '@faker-js/faker': - specifier: ^6.0.0 - version: 6.3.1 '@nestjs/cli': specifier: ^10.1.16 version: 10.1.16(@swc/core@1.3.107) @@ -20957,6 +20954,7 @@ packages: glob@6.0.4: resolution: {integrity: sha512-MKZeRNyYZAVVVG1oZeLaWie1uweH40m9AZwIwxyPbTSX4hHrVYSzLg0Ro5Z5R7XKkIX+Cc6oD1rqeDJnwsB8/A==} + deprecated: Glob versions prior to v9 are no longer supported glob@7.1.4: resolution: {integrity: sha512-hkLPepehmnKk41pUGm3sYxoFs/umurYfYJCerbXEyFIWcAzvpipAgVkBqqT9RBKMGjnq6kMuyYwha6csxbiM1A==} @@ -20977,6 +20975,7 @@ packages: glob@8.1.0: resolution: {integrity: sha512-r8hpEjiQEYlF2QU0df3dS+nxxSIreXQS1qRhMJM0Q5NDdR386C7jb7Hwwod8Fgiuex+k0GFjgft18yvxm5XoCQ==} engines: {node: '>=12'} + deprecated: Glob versions prior to v9 are no longer supported glob@9.3.5: resolution: {integrity: sha512-e1LleDykUz2Iu+MTYdkSsuWX8lvAjAcs0Xef0lNIu0S2wOAzuTxCJtcd9S3cijlwYF18EsU3rzb8jPVobxDh9Q==}