feat(web,novui): initial implementation of var autocomplete in controls #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonjoel82
reviewed
Jul 17, 2024
…to nv-4097-controls-auto-complete-in-the-dashboard
…n-the-dashboard' into nv-4097-controls-auto-complete-in-the-dashboard
…ps://github.com/novuhq/novu into nv-4097-controls-auto-complete-in-the-dashboard
|
@antonjoel82 thanks for the style fixes! It seems to work fine now in web. Will appreciate your final overview and approval so we can merge this 💪 |
antonjoel82
approved these changes
Jul 29, 2024
| }, | ||
| }, | ||
| }, | ||
| staticCss: ['*'], |
There was a problem hiding this comment.
🗒 note (non-blocking): This tells Panda to generate styles for all variants and slots, regardless of which ones are actually used in code. When using defineSlotRecipe, Panda normally only generates classes and styles for recipes that the static checker detects are used in code.
libs/novui/src/json-schema-components/widgets/VariableSuggestionList.tsx
Show resolved
Hide resolved
…ps://github.com/novuhq/novu into nv-4097-controls-auto-complete-in-the-dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer