Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): Change framework capitalization: in_app -> inApp #6477

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

antonjoel82
Copy link
Contributor

@antonjoel82 antonjoel82 commented Sep 10, 2024

What changed? Why was the change needed?

https://linear.app/novu/issue/NV-4283/fix-interface-bug-change-in-app-to-inapp-in-workflow

  • Use casing consistent with step.inApp for Preferences keys
  • Use shared type instead of framework

@antonjoel82 antonjoel82 requested a review from rifont September 10, 2024 17:11
Copy link

linear bot commented Sep 10, 2024

Copy link
Collaborator

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚅

@antonjoel82 antonjoel82 merged commit 36e0596 into next Sep 12, 2024
28 checks passed
@antonjoel82 antonjoel82 deleted the nv-4283-inApp-naming branch September 12, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants