Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate useless DDL when altering column #1480

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Don't generate useless DDL when altering column #1480

merged 1 commit into from
Sep 4, 2020

Conversation

roji
Copy link
Member

@roji roji commented Aug 29, 2020 •
edited
Loading

Fixes #1222

@roji roji requested a review from YohDeadfall as a code owner August 29, 2020 20:14
@roji roji force-pushed the CleanupUselessAlterColumnMigrations branch 4 times, most recently from 3f4d173 to efb2323 Compare August 31, 2020 12:29
@roji roji force-pushed the CleanupUselessAlterColumnMigrations branch from efb2323 to 9aa87bc Compare August 31, 2020 12:50
@roji
Copy link
Member Author

roji commented Sep 4, 2020

@YohDeadfall ping

@roji roji merged commit 210fc07 into npgsql:dev Sep 4, 2020
@roji roji deleted the CleanupUselessAlterColumnMigrations branch September 8, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohDeadfall YohDeadfall YohDeadfall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Altering a column does some superfluous operations
2 participants
@roji @YohDeadfall