Skip to content

Commit 30f95fc

Browse files
committed
Remove process.umask() call from config default
Since we now are using pacote/tar in a way that will rely on the default process umask setting, and we set file/directory modes explicitly anyway, there's no need to have a default umask setting that calls process.umask() As this method is not worker-thread safe, and is deprecated, it's best for us to stop using it. Fix: #1103
1 parent f9d3961 commit 30f95fc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/utils/config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ const defaults = {
170170
'tag-version-prefix': 'v',
171171
timing: false,
172172
tmp: tmpdir(),
173-
umask: process.umask ? process.umask() : 0o22,
173+
umask: 0,
174174
unicode,
175175
'update-notifier': true,
176176
usage: false,

tap-snapshots/test-lib-utils-config.js-TAP.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ Object {
131131
"tag-version-prefix": "v",
132132
"timing": false,
133133
"tmp": "/tmp",
134-
"umask": 18,
134+
"umask": 0,
135135
"unicode": true,
136136
"update-notifier": true,
137137
"usage": false,
@@ -658,7 +658,7 @@ Object {
658658
"tag-version-prefix": "v",
659659
"timing": false,
660660
"tmp": "/tmp",
661-
"umask": 22,
661+
"umask": 0,
662662
"unicode": true,
663663
"update-notifier": true,
664664
"usage": false,
@@ -1185,7 +1185,7 @@ Object {
11851185
"tag-version-prefix": "v",
11861186
"timing": false,
11871187
"tmp": "/tmp",
1188-
"umask": 22,
1188+
"umask": 0,
11891189
"unicode": true,
11901190
"update-notifier": true,
11911191
"usage": false,

0 commit comments

Comments
 (0)