test: fix git configs for git 2.23 and above

Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
npm · Nov 13, 2019 · 5521d1c · 5521d1c
1 parent 2d5c78c
commit 5521d1c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/install/inflate-shrinkwrap.js b/lib/install/inflate-shrinkwrap.js
@@ -84,6 +84,7 @@ function tarballToVersion (name, tb) {
   } else {
     matchRegTarball = new RegExp(`^${registry}(.*)?/-/\\1-(.*)[.]tgz$`)
   }
+  if (!tb) return
   const match = tb.match(matchRegTarball)
   if (!match) return
   return match[2] || match[1]

diff --git a/test/common-tap.js b/test/common-tap.js
@@ -193,7 +193,8 @@ exports.makeGitRepo = function (params, cb) {
     git.chainableExec(['config', 'user.name', user], opts),
     git.chainableExec(['config', 'user.email', email], opts),
     // don't time out tests waiting for a gpg passphrase or 2fa
-    git.chainableExec(['config', 'commit.gpgsign', 'false'], opts),
+    git.chainableExec(['config', 'commit.gpgSign', 'false'], opts),
+    git.chainableExec(['config', 'tag.gpgSign', 'false'], opts),
     git.chainableExec(['config', 'tag.forceSignAnnotated', 'false'], opts),
     git.chainableExec(['add'].concat(added), opts),
     git.chainableExec(['commit', '-m', message], opts)