From 5cfb4879ff404a3c90073aed45659487f8dd9e78 Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Tue, 25 Jul 2023 10:09:49 -0700 Subject: [PATCH] feat: set engines and prerelease for npm 10 BREAKING CHANGE: npm now supports node `^18.17.0 || >=20.5.0` --- .github/workflows/audit.yml | 2 +- .github/workflows/ci-npmcli-docs.yml | 6 +++--- .github/workflows/ci-release.yml | 18 +++++++----------- .github/workflows/ci.yml | 16 +++++++--------- .github/workflows/create-node-pr.yml | 2 +- .github/workflows/release.yml | 4 ++-- package-lock.json | 2 +- package.json | 2 +- release-please-config.json | 2 +- scripts/template-oss/root.js | 1 + 10 files changed, 25 insertions(+), 30 deletions(-) diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml index 806706c2e6bff..8ba559f9dcb60 100644 --- a/.github/workflows/audit.yml +++ b/.github/workflows/audit.yml @@ -26,7 +26,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js diff --git a/.github/workflows/ci-npmcli-docs.yml b/.github/workflows/ci-npmcli-docs.yml index 4df6fc17a0ce6..ca907527f6e84 100644 --- a/.github/workflows/ci-npmcli-docs.yml +++ b/.github/workflows/ci-npmcli-docs.yml @@ -35,7 +35,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js @@ -63,7 +63,7 @@ jobs: os: windows-latest shell: cmd node-version: - - 18.x + - 20.x runs-on: ${{ matrix.platform.os }} defaults: run: @@ -110,7 +110,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js diff --git a/.github/workflows/ci-release.yml b/.github/workflows/ci-release.yml index d3dde52f5979a..cbc7f633c6a7e 100644 --- a/.github/workflows/ci-release.yml +++ b/.github/workflows/ci-release.yml @@ -81,7 +81,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js @@ -116,12 +116,10 @@ jobs: os: windows-latest shell: cmd node-version: - - 14.17.0 - - 14.x - - 16.13.0 - - 16.x - - 18.0.0 + - 18.17.0 - 18.x + - 20.5.0 + - 20.x runs-on: ${{ matrix.platform.os }} defaults: run: @@ -219,12 +217,10 @@ jobs: os: macos-latest shell: bash node-version: - - 14.17.0 - - 14.x - - 16.13.0 - - 16.x - - 18.0.0 + - 18.17.0 - 18.x + - 20.5.0 + - 20.x runs-on: ${{ matrix.platform.os }} defaults: run: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 17b79459c3740..bbb2211d409bc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -43,7 +43,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js @@ -71,12 +71,10 @@ jobs: os: windows-latest shell: cmd node-version: - - 14.17.0 - - 14.x - - 16.13.0 - - 16.x - - 18.0.0 + - 18.17.0 - 18.x + - 20.5.0 + - 20.x runs-on: ${{ matrix.platform.os }} defaults: run: @@ -121,7 +119,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js @@ -147,7 +145,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js @@ -174,7 +172,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js diff --git a/.github/workflows/create-node-pr.yml b/.github/workflows/create-node-pr.yml index 2825623093183..3504f0ed99634 100644 --- a/.github/workflows/create-node-pr.yml +++ b/.github/workflows/create-node-pr.yml @@ -36,7 +36,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4e5fde33cdf3c..95d8473b35f23 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -44,7 +44,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js @@ -156,7 +156,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 20.x cache: npm - name: Check Git Status run: node scripts/git-dirty.js diff --git a/package-lock.json b/package-lock.json index 2b32aeb631904..dbac4c8f90036 100644 --- a/package-lock.json +++ b/package-lock.json @@ -178,7 +178,7 @@ "tap": "^16.3.4" }, "engines": { - "node": "^14.17.0 || ^16.13.0 || >=18.0.0" + "node": "^18.17.0 || >=20.5.0" } }, "docs": { diff --git a/package.json b/package.json index 6e719a073893b..b8415241fbc34 100644 --- a/package.json +++ b/package.json @@ -254,6 +254,6 @@ }, "license": "Artistic-2.0", "engines": { - "node": "^14.17.0 || ^16.13.0 || >=18.0.0" + "node": "^18.17.0 || >=20.5.0" } } diff --git a/release-please-config.json b/release-please-config.json index 389df42704f13..453d831c4c403 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -32,7 +32,7 @@ "packages": { ".": { "package-name": "", - "prerelease": false + "prerelease": true }, "workspaces/arborist": { "prerelease": false diff --git a/scripts/template-oss/root.js b/scripts/template-oss/root.js index 22ddf00264f19..1f7f5efc0c640 100644 --- a/scripts/template-oss/root.js +++ b/scripts/template-oss/root.js @@ -26,6 +26,7 @@ module.exports = { '.github/workflows/release.yml': false, }, }, + ciVersions: ['18.17.0', '18.x', '20.5.0', '20.x'], lockfile: true, npm: '.', defaultBranch: 'latest',