-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update knownBroken
version
#165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I've documented [here](https://github.com/creationix/nvm/blob/master/nvm.sh#L237) in `nvm install-latest-npm`, the last version of `npm` that works on node < v6 is npm v5 - npm v6+ requires node 6.
What breaks with |
Unfortunately I didn't document it in my commit message, but local testing indicates: nvm install 5
npm install -g npm@6.0.0
…
$ npm ls
$HOME/.nvm/versions/node/v5.11.1/lib/node_modules/npm/bin/npm-cli.js:79
let notifier = require('update-notifier')({pkg})
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode Adding |
zkat
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like it breaks after all! Thanks for the PR, we'll be including it in a release soon. 👍 🐑 🚀 💥
This was referenced Feb 1, 2020
This was referenced Sep 15, 2021
This was referenced Feb 15, 2023
This was referenced Jun 1, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've documented here in
nvm install-latest-npm
, the last version ofnpm
that works on node < v6 is npm v5 - npm v6+ requires node 6.