chore: enable mutating flat-options #2802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of files randomly requiring the npm singleton, we pass it where it needs to go so that tests don't need to do so much require mocking everywhere
All output that anything wants to make now goes through `npm.output()`. This is an incremental change getting us closer to where we want to be with testing.
wraithgar
approved these changes
Mar 1, 2021
Member
wraithgar
left a comment
wraithgar
left a comment
There was a problem hiding this comment.
This is a nice small iterative change to get us closer to where we want to be.
Member
|
Tests fail here, not sure why but that obviously needs to be addressed. |
darcyclarke
added
Release 7.x
This will allow for changing configs that are read by commands through flatOptions. Based of npm#2795, land that first. Relates to: npm#2765 Relates to: npm/rfcs#117
ruyadorno
force-pushed
the
mutate-flat-options
branch
from
e233557 to
52c4d3f
Compare
Contributor
Author
|
I'm going to hold off on merging this until we're more certain which direction we want to go with the related workspaces implementation 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for changing configs that are read by commands through
flatOptions.
Relates to: #2765
Relates to: npm/rfcs#117