Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libnpmexec): fix bug not install latest pkg #4929

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

jihunleekr
Copy link
Contributor

@jihunleekr jihunleekr commented May 22, 2022

After the major version of the package is changed (e.g. 0.9 > 1.0 > 2.0)
npx just asks if you want to install it every time
It doesn't actually install.

References

Fixes #4871
Fixes #4619

@jihunleekr jihunleekr requested a review from a team as a code owner May 22, 2022 20:59
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead with this change, I'm pretty sure this will be a more reasonable behavior in terms of UX 👍 thanks @jihunleekr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npx command not install latest package [BUG] npx add confirmation to proceed everytime
3 participants