Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: @npmcli/template-oss@4.19.0 #6812

Merged
merged 1 commit into from
Sep 15, 2023
Merged

chore: @npmcli/template-oss@4.19.0 #6812

merged 1 commit into from
Sep 15, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Sep 15, 2023 •
edited
Loading

v9 backport

@wraithgar wraithgar requested a review from a team as a code owner September 15, 2023 16:51
@lukekarrys
Copy link
Contributor

lukekarrys commented Sep 15, 2023 •
edited
Loading

@wraithgar can you run npm pkg set templateOSS.content='../../scripts/template-oss/index.js' -w workspaces? I noticed in the other template-oss PR that at least workspaces/config/package.json is missing that property. It shouldn't make any changes to npm run template-oss-apply but will be necessary if we make template-oss config changes in the future for workspaces.

@wraithgar
Copy link
Member Author

@lukekarrys that only changed the config workspace so that one you saw was the only outlier. Pushing that now.

@wraithgar wraithgar force-pushed the deps/template-oss-4.19.0 branch from 0148f7e to 99164b2 Compare September 15, 2023 17:00
@wraithgar wraithgar merged commit 608005d into release/v9 Sep 15, 2023
382 of 385 checks passed
@wraithgar wraithgar deleted the deps/template-oss-4.19.0 branch September 15, 2023 17:09
@lukekarrys lukekarrys mentioned this pull request Oct 30, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wraithgar @lukekarrys