Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit timers via proc-log #7378

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Emit timers via proc-log #7378

merged 3 commits into from
Apr 16, 2024

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 15, 2024

This is ready for review but I'm keeping it in draft until #7373 lands as it is based off that.

TODO:

@lukekarrys lukekarrys changed the title lk/proc log time Emit timers via proc-log Apr 15, 2024
@lukekarrys lukekarrys force-pushed the lk/proc-log-deps branch 2 times, most recently from 5ce9e08 to 0bd87c4 Compare April 16, 2024 15:17
Base automatically changed from lk/proc-log-deps to latest April 16, 2024 15:58
@lukekarrys lukekarrys marked this pull request as ready for review April 16, 2024 16:01
@lukekarrys lukekarrys requested a review from a team as a code owner April 16, 2024 16:01

const hasLoadedNpm = npm?.config.loaded

// Unfinished timers can be read before config load
if (npm) {
for (const [name, timer] of npm.unfinishedTimers) {
log.verbose('unfinished npm timer', name, timer)
log.silly('unfinished npm timer', name, timer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukekarrys lukekarrys merged commit 38ed048 into latest Apr 16, 2024
99 of 101 checks passed
@lukekarrys lukekarrys deleted the lk/proc-log-time branch April 16, 2024 16:35
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants