Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(range): inherit options from input range #388

Closed
wants to merge 3 commits into from

Conversation

bluelovers
Copy link
Contributor

BREAKING CHANGE: created new range only if not matched input range

References

BREAKING CHANGE: created new range only if not matched input range
classes/range.js Outdated Show resolved Hide resolved
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@lukekarrys lukekarrys added the semver:major backwards-incompatible breaking changes label Apr 10, 2022
This was linked to issues May 12, 2022
@Researchme

This comment was marked as spam.

@Researchme

This comment was marked as spam.

@Researchme

This comment was marked as spam.

@wraithgar wraithgar requested a review from a team as a code owner April 5, 2023 23:59
@wraithgar wraithgar requested review from fritzy and removed request for a team April 5, 2023 23:59
@wraithgar
Copy link
Member

We're being extra judicious in accepting breaking changes at this point. I am going to close this due to age and lack of any other issues showing that this is something absolutely needed. If the community feels this is important we can revisit it.

@wraithgar wraithgar closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major backwards-incompatible breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://semver.org/.v2.0.0 require('semver')
5 participants