Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure registry option is enforced even when package-lock.json has different resolved #7

Closed
3 tasks done
darcyclarke opened this issue Sep 12, 2019 · 2 comments
Closed
3 tasks done
Assignees

Comments

@darcyclarke
Copy link

darcyclarke commented Sep 12, 2019

There seems to be some confusion around whether the package-lock.json file enforces the destination of the package that is fetched based on the resolved field.

Based on some historical context (ref 1 & 2), I'd like us to test that we do, indeed, respect the registry option when set in .npmrc or --registry and potentially add a test for the scenario where a lock file has disparate references to the provided registry (ref current pickRegistry() tests).

  • Test functionality as it stands today (and confirm the above is true)
  • Write a new test to explicitly test this scenario (ie. a mismatch between resolved paths in package-lock.json vs. a defined registry option)
  • Update docs to explicitly communicate this functionality more thoroughly
@ruyadorno
Copy link
Contributor

A hacky e2e-test-poc was put in place using a fork of npm-registry-mock in which we validate this behavior in a reproducible manner: npm/npm-registry-mock#35

@ruyadorno
Copy link
Contributor

Closing this since we already got all the answers we wanted 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants