Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prepare script respects scriptshell config #389

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

milaninfy
Copy link
Contributor

Prepare script respects scriptshell config if passed matching behaviour of npm run <script>

fixes: npm/cli#7723

@wraithgar
Copy link
Member

This was intentional. It is how, for example, git repos work. The purpose of the prepare lifecycle script is to prepare local directories to work, so this flag was not added here. This flag currently does not differentiate between scripts in your package itself, and those of the packages your are installing, so there is no way for folks to ignore their package's scripts while still being able to install git refs. This is the compromise.

@wraithgar wraithgar closed this Sep 19, 2024
@wraithgar wraithgar reopened this Oct 15, 2024
@wraithgar
Copy link
Member

Not sure how I confused this with the --ignore-scripts flag.

@milaninfy milaninfy force-pushed the mm/respect-scriptshell-config branch from b49b070 to 9e2faea Compare October 15, 2024 14:44
@milaninfy milaninfy marked this pull request as ready for review October 15, 2024 14:46
@milaninfy milaninfy requested a review from a team as a code owner October 15, 2024 14:46
@milaninfy milaninfy force-pushed the mm/respect-scriptshell-config branch from 9e2faea to f6f2cdc Compare October 15, 2024 15:13
@wraithgar wraithgar merged commit cbf94e8 into npm:main Oct 15, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
wraithgar pushed a commit that referenced this pull request Oct 15, 2024
🤖 I have created a release *beep* *boop*
---


## [19.0.1](v19.0.0...v19.0.1)
(2024-10-15)
### Bug Fixes
*
[`cbf94e8`](cbf94e8)
[#389](#389) prepare script respects
scriptshell config (#389) (@milaninfy)
*
[`2b2948f`](2b2948f)
[#403](#403) log tarball retrieval
from cache (#403) (@mbtools, @wraithgar)
### Dependencies
*
[`a9fc4d1`](a9fc4d1)
[#405](#405) bump sigstore from 2.2.0
to 3.0.0 (#405) (@bdehamer)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <prepare script called with CMD on windows>
2 participants