From c57bfeae3f2aa8c8acd6ed05f9713dde6ddf32dc Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Fri, 3 May 2024 14:37:47 -0700 Subject: [PATCH] fix(linting): no-unused-vars --- lib/read-json.js | 4 ++-- test/bin.js | 4 ++-- test/helpful.js | 4 ++-- test/main-non-string.js | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/read-json.js b/lib/read-json.js index d35f09e..d525b7a 100644 --- a/lib/read-json.js +++ b/lib/read-json.js @@ -27,7 +27,7 @@ readJson.extraSet = [ var typoWarned = {} var cache = {} -function readJson (file, log_, strict_, cb_) { +function readJson (file) { var log, strict, cb for (var i = 1; i < arguments.length - 1; i++) { if (typeof arguments[i] === 'boolean') { @@ -154,7 +154,7 @@ function indexjs (file, er, log, strict, cb) { } readJson.extras = extras -function extras (file, data, log_, strict_, cb_) { +function extras (file, data) { var log, strict, cb for (var i = 2; i < arguments.length - 1; i++) { if (typeof arguments[i] === 'boolean') { diff --git a/test/bin.js b/test/bin.js index 738253c..075689d 100644 --- a/test/bin.js +++ b/test/bin.js @@ -5,7 +5,7 @@ var tap = require('tap') var readJson = require('../') var createWarningCollector = function () { - var warn = function (msg) { + var warn = function () { warn.warnings.push(arguments) } warn.warnings = [] @@ -25,7 +25,7 @@ tap.test('Bin test', function (t) { tap.test('Bad bin test', function (t) { var p = path.resolve(__dirname, 'fixtures/badbin.json') var warn = createWarningCollector() - readJson(p, warn, function (er, data) { + readJson(p, warn, function () { t.equal(warn.warnings.length, 1) t.equal(warn.warnings[0][2], 'No bin file found at bin/typo') t.end() diff --git a/test/helpful.js b/test/helpful.js index 9407a6d..8570396 100644 --- a/test/helpful.js +++ b/test/helpful.js @@ -4,7 +4,7 @@ var path = require('path') var p = path.resolve(__dirname, 'fixtures/erroneous.json') tap.test('erroneous package data', function (t) { - readJson(p, function (er, data) { + readJson(p, function (er) { t.ok(er instanceof Error) t.equal(er.code, 'EJSONPARSE') t.end() @@ -12,7 +12,7 @@ tap.test('erroneous package data', function (t) { }) tap.test('ENOTDIR for non-directory packages', function (t) { - readJson(path.resolve(__filename, 'package.json'), function (er, data) { + readJson(path.resolve(__filename, 'package.json'), function (er) { t.ok(er) t.equal(er.code, 'ENOTDIR') t.end() diff --git a/test/main-non-string.js b/test/main-non-string.js index e6eff22..2a0452f 100644 --- a/test/main-non-string.js +++ b/test/main-non-string.js @@ -6,7 +6,7 @@ var p = path.resolve(__dirname, 'fixtures/badmainnonstring.json') tap.test('non-string main entries', function (t) { var logmsgs = [] const warn = (...msg) => logmsgs.push(msg) - readJson(p, warn, function (er, data) { + readJson(p, warn, function (er) { t.comment(logmsgs.map(msg => 'Warning: ' + msg.join(' ')).join('\n')) t.match(er, new TypeError('The "main" attribute must be of type string.')) t.end()