fix: autolocation of node-gyp in make-spawn-args #221
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
safe-require-resolve
branch
3 times, most recently
from
18186ac to
ceef07a
Compare
legobeat
changed the title
legobeat
commented
Sep 30, 2024
| let npm_config_node_gyp | ||
| try { | ||
| /* istanbul ignore next */ | ||
| if (typeof require === 'function' && typeof require.resolve === 'function') { |
There was a problem hiding this comment.
The typeof require may seem redundant here considering we call require('path') just prior.
Rightfully or not, bundlers like webpack and esbuild may transform the direct require() calls but leave require.resolve intact. The extra check prevents runtime errors in such scenarios.
legobeat
force-pushed
the
safe-require-resolve
branch
3 times, most recently
from
ceef07a to
2780f78
Compare
This was referenced Sep 30, 2024
prevents runtime error in environments where `require.resolve` is not available Fall back to any existing `npm_config_node_gyp` provided by environment
legobeat
force-pushed
the
safe-require-resolve
branch
from
2780f78 to
c936a18
Compare
|
@reggi @hashtagchris Some attention on this and #222 would be much appreciated if you are able to 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require.resolveis not available.npm_config_node_gypwhen node-gyp not resolved successfully.Related
npm_config_node_gypenvironment variable andnpm config set node-gypconfig don't work with npm 7 #23node-gyp" not respected in npm 7 cli#2839