Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Define Criteria of Acceptable Breaking Changes w/ Node.js #574

Closed
3 tasks done
Tracked by #585
darcyclarke opened this issue Oct 6, 2022 · 3 comments
Closed
3 tasks done
Tracked by #585
Assignees
Labels

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Oct 6, 2022

Timeline:

  • Collaboration w/ Node.js Release WG: October-November
  • Document Published: Wednesday Nov. 9th

Goal(s):

  • Investigate decoupling npm CLI major updates away from Node.js
  • Define & build written agreement with Node.js Release WG about new major versions of npm
  • @nlf to sync up with @Trott on releases/testing/decoupling major npm versions from node (maybe also get a commit-bit for nodejs/node & become an "official" contributor?)

Links & References

@darcyclarke darcyclarke pinned this issue Oct 17, 2022
@darcyclarke darcyclarke changed the title Initiative: Define Criteria of Acceptable Breaking Changes w/ Node.js Epic: Define Criteria of Acceptable Breaking Changes w/ Node.js Oct 17, 2022
@darcyclarke darcyclarke unpinned this issue Oct 17, 2022
@nlf
Copy link

nlf commented Nov 8, 2022

loose written criteria follows, this will be expanded on in a document that lives elsewhere once we reach consensus with the nodejs team.

  1. No new failures in the nodejs project's tests
  2. No new failures in citgm
  3. No new failures to install package dependencies
  4. No unnecessary changes to the package-lock.json, most notably lockfileVersion upgrades must be explicitly requested

@nlf
Copy link

nlf commented Nov 30, 2022

write up of rules is found here: https://github.com/npm/cli/wiki/Integrating-with-node

i am reaching out to the nodejs team to discuss these rules as well as our testing practices today.

@nlf
Copy link

nlf commented Dec 12, 2022

the wiki write up is our source of truth for this information. i've shared this info with the nodejs team, who have had nothing but positive feedback. at this point our only remaining work is completing the node integration testing workflow. i'm closing this issue as this criteria has now been defined.

@nlf nlf closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants