Allow system, global and local config, similar to how git configs are loaded #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viable config file paths are: * System * `/etc/default/adr-config` * `/etc/adr-config` * Global (user) * `~/.adr-config` * Local (repo) * `$(_adr_dir)/.adr-config` This change relies on `_adr_dir` not trying to load config, so it also incorporates this removal, even though this may have been removed in another branch/PR. Tests are included. If it's not possible to run sudo based tests in the CI/CD system, then these should be removed.
halostatue
pushed a commit
to halostatue/adr-tools
that referenced
this pull request
Jul 20, 2024
Viable config file paths are: * System * `/etc/default/adr-config` * `/etc/adr-config` * Global (user) * `~/.adr-config` * Local (repo) * `$(_adr_dir)/.adr-config` This change relies on `_adr_dir` not trying to load config, so it also incorporates this removal, even though this may have been removed in another branch/PR. Tests are included. If it's not possible to run sudo based tests in the CI/CD system, then these should be removed. npryce#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow system, global and local config, similar to git configs
Viable config file paths are:
/etc/default/adr-config/etc/adr-config~/.adr-config$(_adr_dir)/.adr-configThis change relies on
_adr_dirnot trying to load config, soit also incorporates this removal, even though this may have been
removed in another branch/PR.
Tests are included. If it's not possible to run sudo based tests in
the CI/CD system, then these should be removed.