Skip to content

Example of bug: @nrwl/workspace:run-commands fails if cwd is output path of a @nrwl/*:webpack target #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/cart/project.json
Original file line number Diff line number Diff line change
@@ -107,6 +107,13 @@
}
]
}
},
"run-in-dist":{
"executor": "@nrwl/workspace:run-commands",
"options": {
"cwd": "dist/apps/cart",
"command": "nx run cart:build"
}
}
},
"tags": ["type:app", "scope:cart"],
28 changes: 28 additions & 0 deletions migrations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"migrations": [
{
"cli": "nx",
"version": "14.3.4-beta.1",
"description": "Replace targetDependencies with targetDefaults",
"implementation": "./src/migrations/update-14-3-4/create-target-defaults",
"package": "nx",
"name": "14.3.4-create-target-defaults"
},
{
"version": "14.2.0",
"description": "Explicitly enable sourceAnalysis for all workspaces extending from npm.json or core.json (this was default behavior prior to 14.2)",
"cli": "nx",
"implementation": "./src/migrations/update-14-2-0/enable-source-analysis",
"package": "@nrwl/workspace",
"name": "14-2-0-enable-source-analysis"
},
{
"cli": "nx",
"version": "14.2.3-beta.0",
"description": "Adds @swc/core and @swc-node as a dev dep if you are using them (repeated due to prior mistake)",
"factory": "./src/migrations/update-14-1-9/add-swc-deps-if-needed",
"package": "@nrwl/linter",
"name": "add-swc-deps-again"
}
]
}
15 changes: 6 additions & 9 deletions nx.json
Original file line number Diff line number Diff line change
@@ -20,14 +20,6 @@
}
}
},
"targetDependencies": {
"build": [
{
"target": "build",
"projects": "dependencies"
}
]
},
"cli": {
"warnings": {
"versionMismatch": false
@@ -50,5 +42,10 @@
}
},
"defaultProject": "products",
"$schema": "./node_modules/nx/schemas/nx-schema.json"
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"targetDefaults": {
"build": {
"dependsOn": ["^build"]
}
}
}
51 changes: 26 additions & 25 deletions package.json
Original file line number Diff line number Diff line change
@@ -37,22 +37,22 @@
"@angular/platform-browser-dynamic": "14.0.0",
"@angular/router": "14.0.0",
"@emotion/babel-plugin": "11.9.2",
"@emotion/react": "11.9.0",
"@emotion/styled": "11.8.1",
"@emotion/react": "11.9.3",
"@emotion/styled": "11.9.3",
"@ngrx/component-store": "13.2.0",
"@ngrx/effects": "13.2.0",
"@ngrx/entity": "13.2.0",
"@ngrx/router-store": "13.2.0",
"@ngrx/store": "13.2.0",
"@nrwl/angular": "14.2.0-rc.1",
"@nrwl/angular": "14.3.6",
"core-js": "^2.5.4",
"document-register-element": "1.13.1",
"normalize.css": "^8.0.1",
"react": "18.1.0",
"react-dom": "18.1.0",
"react-is": "18.1.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-is": "18.2.0",
"react-router-dom": "6.3.0",
"react-test-renderer": "18.1.0",
"react-test-renderer": "18.2.0",
"rxjs": "~6.5.5",
"tslib": "^2.0.0",
"zone.js": "0.11.4"
@@ -66,21 +66,21 @@
"@angular/compiler-cli": "14.0.0",
"@angular/language-service": "14.0.0",
"@ngrx/store-devtools": "13.2.0",
"@nrwl/cli": "14.2.0-rc.1",
"@nrwl/cypress": "14.2.0-rc.1",
"@nrwl/devkit": "14.2.0-rc.1",
"@nrwl/eslint-plugin-nx": "14.2.0-rc.1",
"@nrwl/jest": "14.2.0-rc.1",
"@nrwl/linter": "14.2.0-rc.1",
"@nrwl/nx-cloud": "14.0.5",
"@nrwl/react": "14.2.0-rc.1",
"@nrwl/web": "14.2.0-rc.1",
"@nrwl/workspace": "14.2.0-rc.1",
"@testing-library/react": "13.1.1",
"@nrwl/cli": "14.3.6",
"@nrwl/cypress": "14.3.6",
"@nrwl/devkit": "14.3.6",
"@nrwl/eslint-plugin-nx": "14.3.6",
"@nrwl/jest": "14.3.6",
"@nrwl/linter": "14.3.6",
"@nrwl/nx-cloud": "14.1.2",
"@nrwl/react": "14.3.6",
"@nrwl/web": "14.3.6",
"@nrwl/workspace": "14.3.6",
"@testing-library/react": "13.3.0",
"@types/jest": "27.4.1",
"@types/node": "14.14.33",
"@types/react": "18.0.8",
"@types/react-dom": "18.0.3",
"@types/node": "18.0.0",
"@types/react": "18.0.13",
"@types/react-dom": "18.0.5",
"@types/react-router-dom": "5.3.3",
"@typescript-eslint/eslint-plugin": "5.24.0",
"@typescript-eslint/parser": "5.24.0",
@@ -90,18 +90,19 @@
"eslint-config-prettier": "8.1.0",
"eslint-plugin-cypress": "^2.10.3",
"eslint-plugin-jsx-a11y": "6.4.1",
"eslint-plugin-react": "7.29.4",
"eslint-plugin-react-hooks": "4.5.0",
"eslint-plugin-react": "7.30.0",
"eslint-plugin-react-hooks": "4.6.0",
"fuzzy": "^0.1.3",
"inquirer": "^6.2.2",
"inquirer-autocomplete-prompt": "^1.0.1",
"jest": "27.5.1",
"jest-preset-angular": "11.1.2",
"netlify": "^2.4.8",
"nx": "14.2.0-rc.1",
"nx": "14.3.6",
"prettier": "2.6.2",
"ts-jest": "27.1.4",
"ts-node": "9.1.1",
"ts-node": "10.8.1",
"typescript": "4.7.2"
}
}

1,052 changes: 788 additions & 264 deletions yarn.lock

Large diffs are not rendered by default.