Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't seem to use go get on /rest #104

Closed
marcolussetti opened this issue Jun 30, 2020 · 2 comments
Closed

Can't seem to use go get on /rest #104

marcolussetti opened this issue Jun 30, 2020 · 2 comments

Comments

@marcolussetti
Copy link

marcolussetti commented Jun 30, 2020

Can't seem to get the rest sub-package. At first I thought it was likely user error on my part, but I'm not so sure anymore.

Updated description/cause:

v2.4.0 from 28 days ago (https://github.com/ns1/ns1-go/releases/tag/v2.4.0) seems to be pointing to the wrong commit:
7c167e5 which is from 2016 (really a v1 commit?)

Take a peek inside go/src/gopkg.in/ns1/ns1-go.v2 at the git repo:
image

Original notes:

C:\Users\REMOVED>go get gopkg.in/ns1/ns1-go.v2/rest
package gopkg.in/ns1/ns1-go.v2/rest: cannot find package "gopkg.in/ns1/ns1-go.v2/rest" in any of:
        c:\go\src\gopkg.in\ns1\ns1-go.v2\rest (from $GOROOT)
        C:\Users\REMOVED\go\src\gopkg.in\ns1\ns1-go.v2\rest (from $GOPATH)

And if I check in the directory, it is indeed missing the rest directory:
image

Tried combinations of fetching package first, then subpackage, and viceversa. It seems like the issue is actually related to release tagging.

@marcolussetti
Copy link
Author

Also seems like it's pointing to the master branch which is from 2016, rather than v2.

@Zach-Johnson
Copy link
Contributor

@marcolussetti thanks for bringing this to our attention - it looks like we did indeed mis-tag our last release. I've just pushed up tag v2.4.1, which should be correct now. I'm going to close this issue, but feel free to re-open if you still encounter problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants