Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content about hack days to our docs #514

Merged

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Apr 10, 2024

Right now, our announcement thread is the best place to link folks to learn about hack days. A permanent page in our docs is probably more useful! As we change our ways of collaborating with the public, e.g. transitioning to office hours?, we could update this page.

@mfisher87 mfisher87 requested a review from asteiker April 10, 2024 17:11
mfisher87 added a commit to mfisher87/approach-guide that referenced this pull request Apr 10, 2024
The linked hack day page doesn't exist yet; it will soon when this PR is merged: nsidc/earthaccess#514
Copy link
Member

@asteiker asteiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattF-NSIDC this is a great addition to our docs. Let's sync up with @andypbarrett on his PR #498, as he's put a lot of thought into organizational improvements to the documentation. It also may make the most sense to merge his PR first, and then iterate with this addition. As far as the content itself, I have additional thoughts on this and would like to spend more time at tomorrow's hackday (very apropros!) to develop more details on the "who" and "how" we work, if you don't mind me bulking it up a bit more!

mkdocs.yml Outdated
@@ -49,6 +49,7 @@ nav:
- OVERVIEW:
- "Readme": "index.md"
- "Getting started": "tutorials/getting-started.ipynb"
- "Work with us!": "work-with-us.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattF-NSIDC I love the idea of placing this page front and center under the Overview. I'm also wondering whether it makes sense to connect it with the Contributing guide somehow? I get a little stuck sometimes with the navigation in our readthedocs since we have a more technical-focused TOC on the righthand side of the page. But again I think this is a great spot for it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also reminded of @andypbarrett 's PR #498 which is overhauling the existing structure. Let's coordinate on the best placement for this based on Andy's analysis.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps work-with-us.md becomes a sub page of https://earthaccess--498.org.readthedocs.build/en/498/ (the default Welcome page)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps work-with-us.md becomes a sub page of https://earthaccess--498.org.readthedocs.build/en/498/ (the default Welcome page)?

Like a section on that page? For my personal taste, that page is getting a bit long and I would really like to break it up a bit, e.g. separate top-level items (or expanded sub-items of "welcome") on the sidebar. E.g.:

  • Welcome: Prose introducing the project
    • Quick start: Installing & Getting data in 3 steps
    • Work with us: Contributors and prose
      • Contributing guide
      • Collaboration events (?)
    • Talks & external resources (perhaps this could even be moved in to reference or if we want, a new "explanation" section for the 4th diataxis quadrant... but maybe that's a separate topic 😄)
  • HOW-TO
  • TUTORIALS
  • USER REFERENCE
  • EXPLANATION

Let's chat more tomorrow :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also wondering whether it makes sense to connect it with the Contributing guide somehow? I get a little stuck sometimes with the navigation in our readthedocs since we have a more technical-focused TOC on the righthand side of the page.

Yes, this makes a lot of sense to me also. I created #521 earlier today because I was thinking about how hard-to-navigate that page was getting :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on to #498

@mfisher87 mfisher87 force-pushed the docs-work-with-us-page branch from 2b5a560 to 3a95b7a Compare April 19, 2024 22:14
@mfisher87 mfisher87 changed the base branch from main to update-documentation April 19, 2024 22:15
@mfisher87
Copy link
Collaborator Author

@andypbarrett this PR now targets your documentation branch. If you're good with this, please merge it :)

@mfisher87 mfisher87 force-pushed the docs-work-with-us-page branch from 95239ce to 07c6c83 Compare April 19, 2024 22:43
@mfisher87 mfisher87 changed the base branch from update-documentation to main April 19, 2024 23:27
@mfisher87 mfisher87 changed the base branch from main to update-documentation April 19, 2024 23:27
@mfisher87 mfisher87 requested a review from andypbarrett April 19, 2024 23:28
@andypbarrett andypbarrett merged commit 09f2cf7 into nsidc:update-documentation Apr 24, 2024
10 of 11 checks passed
@mfisher87 mfisher87 deleted the docs-work-with-us-page branch April 25, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants