From 4ffd3ffae5cab2b5ebf5daa49c6cac2a6c8f9afd Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Thu, 18 Jan 2024 13:24:23 +0100 Subject: [PATCH] update length expectations --- tests/testthat/test-2_ggproto_visualize.r | 9 +++++---- tests/testthat/test-zDepricated_2_render.R | 2 +- tests/testthat/test-zDepricated_3_visualize.r | 10 ++++++---- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/testthat/test-2_ggproto_visualize.r b/tests/testthat/test-2_ggproto_visualize.r index b70c3aa..04b898d 100644 --- a/tests/testthat/test-2_ggproto_visualize.r +++ b/tests/testthat/test-2_ggproto_visualize.r @@ -65,14 +65,15 @@ fs_gt <- filmstrip(gg_gt ) fs_mt1d <- filmstrip(gg_mt1d) fs_gt1d <- filmstrip(gg_gt1d) test_that("filmstrip", { + expected_length <- length(ggplot2::ggplot()) expect_equal(class(fs_mt ), c("gg", "ggplot")) expect_equal(class(fs_gt ), c("gg", "ggplot")) expect_equal(class(fs_mt1d), c("gg", "ggplot")) expect_equal(class(fs_gt1d), c("gg", "ggplot")) - expect_equal(length(fs_mt ), 9L) - expect_equal(length(fs_gt ), 9L) - expect_equal(length(fs_mt1d), 9L) - expect_equal(length(fs_gt1d), 9L) + expect_equal(length(fs_mt ), expected_length) + expect_equal(length(fs_gt ), expected_length) + expect_equal(length(fs_mt1d), expected_length) + expect_equal(length(fs_gt1d), expected_length) }) ## proto_basis ----- diff --git a/tests/testthat/test-zDepricated_2_render.R b/tests/testthat/test-zDepricated_2_render.R index 2d73c65..20e4a72 100644 --- a/tests/testthat/test-zDepricated_2_render.R +++ b/tests/testthat/test-zDepricated_2_render.R @@ -27,7 +27,7 @@ suppressWarnings( ## suppress 8hr deprecation warning test_that("render_, class and dim", { expect_equal(class(ret) , c("gg", "ggplot")) - expect_equal(length(ret), 9L) + expect_equal(length(ret), length(ggplot2::ggplot())) }) ### render_gganimate ----- diff --git a/tests/testthat/test-zDepricated_3_visualize.r b/tests/testthat/test-zDepricated_3_visualize.r index b9d3bbb..2a69ec6 100644 --- a/tests/testthat/test-zDepricated_3_visualize.r +++ b/tests/testthat/test-zDepricated_3_visualize.r @@ -77,10 +77,11 @@ suppressWarnings( ## suppress 8hr deprecation warning ) test_that("view_frame: gganimate class and length", { + expected_length <- length(ggplot2::ggplot()) expect_equal(class(ret_light), c("gg", "ggplot")) expect_equal(class(ret_heavy), c("gg", "ggplot")) - expect_equal(length(ret_light), 9L) - expect_equal(length(ret_heavy), 9L) + expect_equal(length(ret_light), expected_length) + expect_equal(length(ret_heavy), expected_length) }) @@ -96,9 +97,10 @@ suppressWarnings( ## suppress 8hr deprecation warning ) test_that("view_manip_space: gganimate class and length", { + expected_length <- length(ggplot2::ggplot()) expect_equal(class(ret_light), c("gg", "ggplot")) expect_equal(class(ret_heavy), c("gg", "ggplot")) - expect_equal(length(ret_light), 9L) - expect_equal(length(ret_heavy), 9L) + expect_equal(length(ret_light), expected_length) + expect_equal(length(ret_heavy), expected_length) })