Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqd: Support a custom CA for communicating with nsqauth #1464

Closed
intellitrend-team opened this issue Oct 11, 2023 · 4 comments
Closed

nsqd: Support a custom CA for communicating with nsqauth #1464

intellitrend-team opened this issue Oct 11, 2023 · 4 comments

Comments

@intellitrend-team
Copy link
Contributor

We are using NSQ in production and are loving the experience.
We have implemented a custom nsqauth server and would like to encrypt the connection between nsqd and this endpoint with TLS because we don't want our authentication secrets to be sent over an unencrypted connection (potentially over an untrusted network).

Separating nsqd and the nsqauth server is common in cloud environments, where no assumptions about the network security should be made.

Passing an https:// URL to --auth-http-address works fine if the server-side certificate is trusted by the system CA pool, but self-signed certificates / custom CAs are not accepted by default, of course.
The --tls-root-ca-file is not respected for the auth HTTP request either, the *tls.Config in http.ClientTransport.TLSClientConfig is simply set to nil.
Adding a flag to support a custom CA or simply including the existing --tls-root-ca-file in the cert pool would greatly simplify encrypting the connection with a custom certificate.

@mreiferson
Copy link
Member

I think this sounds reasonable, would you be interested in submitting a PR?

@UtR491
Copy link

UtR491 commented Nov 4, 2023

@mreiferson can I take this one up, in case no one is working on it?

@intellitrend-team
Copy link
Contributor Author

We have this feature implemented and working on our side already, so we can submit a PR on Monday.

@intellitrend-team
Copy link
Contributor Author

If you have any more questions and suggestions for the PR, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants