fix(camera-plus): fixes outstanding issues #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this @Logikgate and sorry for delay on processing. We are going to bring several patches together on ios runtime including your PR and publish another 'rc' to validate this changeset against and will try to get a patch published next week on this. |
|
@nativescript/ios |
|
@Logikgate testing this and appears a crash still occurs. It's interesting as it seems to crash on just the Not sure if you had seen anything similar at anytime? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12
The first issue in #12 was fixed by NathanWalker/SwiftyCam#10.
The second issue is fixed by this pull request, the methods needed to be exposed to objective-c so they could be called natively.
Leaving this as a WIP for now because it relies on NativeScript/ios#116 being merged and a new version of the runtime being released.