# Mentor Meeting
##### Team: Powell's Owls | Group 33
#### Overview
| Date       | Time      | Type of Meeting   | Where   |
| ---------- | --------- | ----------------- | ------- |
| 03/12/2021 | 5-5:45pm  | Mentor            | Zoom    |

---

### Agenda
1. Go over sprint retrospective
2. Updates on progress of final sprint

---

### Key Points
#### Retrospective
1. Challenges
- switched to eslinter instead of GitHub built in which created a lot of merge conflicts & people had to spend time re-doing their styles
  - this was mainly due to lack of knowledge about linters but now our code looks more cohesive
- testing was challenging because of Shadow DOM & we have way more cypress vs Jest tests because of this
  - while this made testing hard, it's good we used Shadow DOM because it makes our component architecture stronger and better in scope
  - took a long time to figure out event listeners (custom events), and calling functions within shadow
- having issues normalizing css across different browsers
- our PRs should have been a bit more granular and we should have just added more in incrementally
  - instead, we have major PRs for whole components that required a lot of tweaks bc of new standards or changes and so we had to wait to merge those PRs in because of the new changes
  - if we'd done smaller PRs, we could have merged more in sooner
  - however, we waited because we were still finalizing a lot of things like the linter and ensuring the architecture was running smoothly
  - this also backed up testing bc testers had to work on individual branches    
2. What worked well
- office hours were a hit and helped people resolve issues
  - it also allowed for more collaboration among team members
- checkins/standups are getting better (more engagement)
- we discuss ADRs or make design decisions in our meetings and then immediately do documentation so we've kept up on that front
- we have pretty thorough testing and style checking for the code base
- when reviewing PRs, usually we have 2-3 people and they take checking it very seriously
  - it may slow down the pipeline but the comments and overall feedback are very important
3. Improvements
- make PRs smaller and more granular to merge more in
- have a more even work distribution
  - it's very clear some people are working more than others
- finalize css asap

#### Updates on Sprint
1. Richard: worked on keystroke accessibility + toggle switch custom component + local storage file + drafting up the content for the info page
2. Michael + Brandon: worked together on polishing up sidebar (dark & light mode css) + adding error css/input validation
3. Felix: window resizing + mobile view + rescaling to make sure text shrinks and positioning is centered + manually checked zoom in/out
4. Bryant: did code quality/styling by looking through every single file and giving feedback to people + updated IDs/classes to match new standards + refactored timer tests + started re-checking tests to make sure none are stale
5. Vy: updated stats page to reflect new changes + rewrote unit tests + had to resolve many conflicts with main (to PR) + started doing dark/light mode styling and function
6. Steven: set up a whole new linter (for JS, test, and css) + helped people resolve linting conflicts + now people can run linter locally
7. Lulu: no updates
---

### Attendance
- [x] Michael Donaldson
- [x] Richard Duong
- [x] Brandon Liu
- [x] Bryant Shao
- [x] Steven Steiner
- [x] Nicole Trappe
- [x] Vy Truong
- [x] Felix Zhang
- [ ] Lulu Zhu