Add the detector table to our hdf5 files #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this is the best way to do this it might be possible to just iterate over the tpc_ids instead of adding them for each event I will take more time for to think about this
oops it was not there before
vhewes
requested changes
Nov 27, 2023
There was a problem hiding this comment.
this is looking good! i notice a lot of cases of newlines and indents being added, so most of my review comments are just about reverting those.
i haven't tested these changes, but if you're able to run them and they produce good output, then i'm pretty much happy with the content. i think my note on using scalar values instead of an array for the center was my only note on the content. great work!
also fix whitespaces and indentations
vhewes
reviewed
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11