Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make symbol resolution lazy #873

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make symbol resolution lazy #873

wants to merge 3 commits into from

Commits on Aug 22, 2022

  1. Refactor native library loading 

    This simplifies the process of supporting multiple paths for native
code loading and allows cleanup to occur on non-windows platforms when
the libllvmlite shared library is extracted to a temporary directory.
    @folded
    folded committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3e49248 View commit details
    Browse the repository at this point in the history

  2. Avoid potential race condition in symbol lookup. 

    If two threads attempt to resolve the same symbol at the same time,
then both may test the symbol dictionary before the other has a chance
to insert a wrapper object, leading to both threads creating their
own wrapper.

Add double checked locking to avoid this possibility.
    @folded
    folded committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    134c9ea View commit details
    Browse the repository at this point in the history

  3. Make symbol resolution lazy 

    This delays the lookup of a symbol until it is first called, which
in turn allows us to write a test for extraction of native code from
a package.
    @folded
    folded committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9cb76ae View commit details
    Browse the repository at this point in the history