Change linting rules to error.

Author: seanwu1105

.eslintrc.json

@@ -17,7 +17,7 @@
       ],
       "rules": {
         "no-console": "error",
-        "prefer-const": "warn",
+        "prefer-const": "error",
         "no-param-reassign": "error",
         "no-else-return": "error",
         "max-len": [
@@ -30,7 +30,7 @@
             "ignoreRegExpLiterals": true
           }
         ],
-        "class-methods-use-this": "warn",
+        "class-methods-use-this": "error",
         "no-magic-numbers": "off", // must disable the base rule as it can report incorrect errors
         "@typescript-eslint/no-magic-numbers": [
           "error",
@@ -43,30 +43,30 @@
         "@typescript-eslint/explicit-module-boundary-types": "off",
         "@typescript-eslint/no-explicit-any": "off",
         "@typescript-eslint/no-unused-vars": [
-          "warn",
+          "error",
           { "argsIgnorePattern": "^_" }
         ],
         "@typescript-eslint/array-type": "error",
         "no-constant-condition": "off",
         "@typescript-eslint/no-unnecessary-condition": [
-          "warn",
+          "error",
           {
             "allowConstantLoopConditions": true
           }
         ],
-        "@typescript-eslint/no-unnecessary-qualifier": "warn",
-        "@typescript-eslint/no-unnecessary-type-arguments": "warn",
-        "@typescript-eslint/prefer-for-of": "warn",
-        "@typescript-eslint/prefer-function-type": "warn",
-        "@typescript-eslint/prefer-includes": "warn",
-        "@typescript-eslint/prefer-nullish-coalescing": "warn",
-        "@typescript-eslint/prefer-optional-chain": "warn",
-        "@typescript-eslint/prefer-readonly": "warn",
-        "@typescript-eslint/prefer-as-const": "warn",
-        "@typescript-eslint/prefer-string-starts-ends-with": "warn",
-        "@typescript-eslint/prefer-ts-expect-error": "warn",
+        "@typescript-eslint/no-unnecessary-qualifier": "error",
+        "@typescript-eslint/no-unnecessary-type-arguments": "error",
+        "@typescript-eslint/prefer-for-of": "error",
+        "@typescript-eslint/prefer-function-type": "error",
+        "@typescript-eslint/prefer-includes": "error",
+        "@typescript-eslint/prefer-nullish-coalescing": "error",
+        "@typescript-eslint/prefer-optional-chain": "error",
+        "@typescript-eslint/prefer-readonly": "error",
+        "@typescript-eslint/prefer-as-const": "error",
+        "@typescript-eslint/prefer-string-starts-ends-with": "error",
+        "@typescript-eslint/prefer-ts-expect-error": "error",
         "@typescript-eslint/promise-function-async": [
-          "warn",
+          "error",
           { "checkArrowFunctions": false }
         ],
         "@angular-eslint/component-class-suffix": [
@@ -91,7 +91,7 @@
             "style": "camelCase"
           }
         ],
-        "rxjs/finnish": "warn",
+        "rxjs/finnish": "error",
         "rxjs/no-ignored-notifier": "off"
       }
     },