[issue] license URL is wrong on asset profile

[sync-by-unito]

User story

As a user who relies on accurate licensing information for digital assets, I want the license URL on the asset profile to be correct and accessible so that I can easily understand and adhere to the licensing terms of the asset.

Reproduce step

1. See this asset
2. the license is link to https://creativecommons.org/licenses/by-nd/4.0/

Expectation

It should be https://creativecommons.org/licenses/by-nc-nd/4.0/legalcode

Additional information:

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

[sync-by-unito]

➤ Scott Yan commented:

Kenny Hung 請問一下這一個連結是 commit 就錯了嗎 ? 還是只是 asset profile 這邊錯而已~~~

[sync-by-unito]

➤ Kenny Hung commented:

asset profile錯而已，commit是對的

[sync-by-unito]

➤ Ethan Wu commented:

can you provide the link to the asset in question?

[sync-by-unito]

➤ Kenny Hung commented:

asset: https://nftsearch.site/asset-profile?cid=bafybeigzs2casryt6ivxspttqqlj5cupqarpvdm2g2upfzq7g6u4bpnd7a ( https://nftsearch.site/asset-profile?cid=bafybeigzs2casryt6ivxspttqqlj5cupqarpvdm2g2upfzq7g6u4bpnd7a )

the license is CC-BY-NC-ND-4.0

the link should be https://creativecommons.org/licenses/by-nc-nd/4.0/legalcode ( https://creativecommons.org/licenses/by-nc-nd/4.0/legalcode )

But asset profile license link to https://creativecommons.org/licenses/by-nd/4.0/ ( https://creativecommons.org/licenses/by-nd/4.0/ )

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung was this asset created after the dashboard change?

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu No, not only the asset from dashboard, I suppose this issue is from nse-bubble.

Because asset after mint & share, the link is wrong, but the assetTree is right.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung ok i know what the issue is. i will make the adjustment.

[sync-by-unito]

➤ Ethan Wu commented:

this is done.

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu I try this asset ( https://nftsearch.site/version-8auz/asset-profile?cid=bafybeigzs2casryt6ivxspttqqlj5cupqarpvdm2g2upfzq7g6u4bpnd7a ) through v230907 branch, the license URL still wrong. It should be

https://creativecommons.org/licenses/by-nc-nd/4.0/legalcode ( https://creativecommons.org/licenses/by-nc-nd/4.0/legalcode )

instead of https://creativecommons.org/licenses/by-nd/4.0/legalcode ( https://creativecommons.org/licenses/by-nd/4.0/legalcode ).

[sync-by-unito]

➤ Ethan Wu commented:

let me fix one sec.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung i made the fix. note that the only reason why the license shows up for this asset is because the asset is in storage backend and we default all license to cc-by-nc-nd-4.0 when the license is empty (due to fullassettree api response not working properly)

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu Just want to confirm, the license information doesn't fetch from assetTree?

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung for this asset no. currently as mentioned in the huddle, the getFullAssetTree api call only can fetch license information if there is just one commit. if there is more than one than it cannot grab it.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung there is workflows in search engine that sets the default license to cc-by-nc-nd-4.0 if the asset is in storage backend

[sync-by-unito]

➤ Kenny Hung commented:

Got it, so this issue needs to fix pipedream API first, am I right?

[sync-by-unito]

➤ Ethan Wu commented:

that is correct.

[sync-by-unito]

➤ Kenny Hung commented:

QA test pass.https://nftsearch.site/version-8auz/asset-profile?cid=bafybeigzs2casryt6ivxspttqqlj5cupqarpvdm2g2upfzq7g6u4bpnd7a ( https://nftsearch.site/version-8auz/asset-profile?cid=bafybeigzs2casryt6ivxspttqqlj5cupqarpvdm2g2upfzq7g6u4bpnd7a )