Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture App does not upload the signed message to backend #778

Closed
shc261392 opened this issue Jul 12, 2021 · 0 comments
Closed

Capture App does not upload the signed message to backend #778

shc261392 opened this issue Jul 12, 2021 · 0 comments
Assignees
Labels
bug Something isn't working fix/feature verified The fix has been verified by QA priority:critical Critical priority
Milestone

Comments

@shc261392
Copy link
Contributor

Description

The message content signed in App (serialized signedTargets) is different from the string uploaded to DIA backend as meta field. Currently, the App never provide the correct signed message to backend in any way.

In order to verify the signature using the information stored on the backend, the App must have a way to upload the signed message to backend for all assets created from the App.

Environment

  • Version:All

Limitation

Because the generated key pair is destroyed when the App is deleted, if the user ever deletes the App even once, we have no way to remake signatures with the original key pair for the assets created before the user deletes the App. (It's meaningless anyway since the user also lost their wallet when deleting the App)

We could use the new key pair to generate a completely new signature though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix/feature verified The fix has been verified by QA priority:critical Critical priority
Projects
None yet
Development

No branches or pull requests

2 participants