From 1ab64818b8364fd8a5f0fbb9ac14c9ab2c1271d4 Mon Sep 17 00:00:00 2001 From: Terje Sandstrom Date: Sun, 4 Aug 2024 23:22:28 +0200 Subject: [PATCH 1/5] Update for nunit 4.2 --- docs/articles/nunit/release-notes/framework.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/articles/nunit/release-notes/framework.md b/docs/articles/nunit/release-notes/framework.md index c95b370a8..e79478e10 100644 --- a/docs/articles/nunit/release-notes/framework.md +++ b/docs/articles/nunit/release-notes/framework.md @@ -7,10 +7,11 @@ uid: frameworkreleasenotes ## NUnit 4.2 - To Be released very soon now -There are 28 issues fixed in this release. +There are 31 issues fixed in this release. ### Enhancements +* [4738](https://github.com/nunit/nunit/issues/4738) QoL suggestion: fail fast in Assert.Multiple under debugger. * [4710](https://github.com/nunit/nunit/issues/4710) Improve PropertiesComparer diagnostics. Fixed by team [PR 4712](https://github.com/nunit/nunit/pull/4712) * [4353](https://github.com/nunit/nunit/issues/4353) TestContext.AddTestAttachment with long file paths. Thanks to [Rohit Aggarwal](https://github.com/Meet2rohit99) for [PR 4665](https://github.com/nunit/nunit/pull/4665) * [3918](https://github.com/nunit/nunit/issues/3918) String comparison without whitespace. Fixed by team [PR 4664](https://github.com/nunit/nunit/pull/4664) @@ -23,6 +24,7 @@ There are 28 issues fixed in this release. ### Bug fixes +* [4770](https://github.com/nunit/nunit/issues/4770) Bug report: [Values] doesn't play nice with [CancelAfter]. * [4750](https://github.com/nunit/nunit/issues/4750) `DefaultFloatingPointTolerance` ignored for `TestCaseData`. Fixed by team [PR 4754](https://github.com/nunit/nunit/pull/4754) * [4723](https://github.com/nunit/nunit/issues/4723) CurrentContext.Result.Outcome.Status is inconclusive in TearDown if Timeout attribute is used in 4.x. Fixed by team [PR 4727](https://github.com/nunit/nunit/pull/4727) * [4705](https://github.com/nunit/nunit/issues/4705) The dll's in the release 4.1 has version 4.0.1. Fixed by team [PR 4706](https://github.com/nunit/nunit/pull/4706) @@ -32,6 +34,7 @@ There are 28 issues fixed in this release. * [4639](https://github.com/nunit/nunit/issues/4639) `ValueTask` is not being properly consumed by the `AwaitAdapter`. Fixed by team [PR 4640](https://github.com/nunit/nunit/pull/4640) * [4598](https://github.com/nunit/nunit/issues/4598) DefaultTimeout in .runsettings + TearDown method seems to break test output. Fixed by team [PR 4692](https://github.com/nunit/nunit/pull/4692) * [4589](https://github.com/nunit/nunit/issues/4589) Exception when using test filters from .runsettings or --filter argument from dotnet test. Fixed by team [PR 4760](https://github.com/nunit/nunit/pull/4760) +* [4584](https://github.com/nunit/nunit/issues/4584) Nunit 4.0.x Test case selection is incorrect with certain test data. * [1358](https://github.com/nunit/nunit/issues/1358) TestContext.CurrentContext.Test.Properties does not contain value(s) from PropertyAttribute when using TestCaseAttribute. Fixed by team [PR 4757](https://github.com/nunit/nunit/pull/4757) ### Refactorings From d52e4e1452fb702c2b328905943610d917920b27 Mon Sep 17 00:00:00 2001 From: Terje Sandstrom Date: Sun, 4 Aug 2024 23:41:22 +0200 Subject: [PATCH 2/5] Update for nunit 4.2 --- docs/articles/nunit/release-notes/framework.md | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/articles/nunit/release-notes/framework.md b/docs/articles/nunit/release-notes/framework.md index e79478e10..91f67a684 100644 --- a/docs/articles/nunit/release-notes/framework.md +++ b/docs/articles/nunit/release-notes/framework.md @@ -11,7 +11,7 @@ There are 31 issues fixed in this release. ### Enhancements -* [4738](https://github.com/nunit/nunit/issues/4738) QoL suggestion: fail fast in Assert.Multiple under debugger. +* [4738](https://github.com/nunit/nunit/issues/4738) QoL suggestion: fail fast in Assert.Multiple under debugger. Thanks to [MaceWindu](https://github.com/MaceWindu) for [PR 4749](https://github.com/nunit/nunit/pull/4749) * [4710](https://github.com/nunit/nunit/issues/4710) Improve PropertiesComparer diagnostics. Fixed by team [PR 4712](https://github.com/nunit/nunit/pull/4712) * [4353](https://github.com/nunit/nunit/issues/4353) TestContext.AddTestAttachment with long file paths. Thanks to [Rohit Aggarwal](https://github.com/Meet2rohit99) for [PR 4665](https://github.com/nunit/nunit/pull/4665) * [3918](https://github.com/nunit/nunit/issues/3918) String comparison without whitespace. Fixed by team [PR 4664](https://github.com/nunit/nunit/pull/4664) @@ -24,7 +24,7 @@ There are 31 issues fixed in this release. ### Bug fixes -* [4770](https://github.com/nunit/nunit/issues/4770) Bug report: [Values] doesn't play nice with [CancelAfter]. +* [4770](https://github.com/nunit/nunit/issues/4770) Bug report: [Values] doesn't play nice with [CancelAfter]. Fixed by team [PR 4774](https://github.com/nunit/nunit/pull/4774) * [4750](https://github.com/nunit/nunit/issues/4750) `DefaultFloatingPointTolerance` ignored for `TestCaseData`. Fixed by team [PR 4754](https://github.com/nunit/nunit/pull/4754) * [4723](https://github.com/nunit/nunit/issues/4723) CurrentContext.Result.Outcome.Status is inconclusive in TearDown if Timeout attribute is used in 4.x. Fixed by team [PR 4727](https://github.com/nunit/nunit/pull/4727) * [4705](https://github.com/nunit/nunit/issues/4705) The dll's in the release 4.1 has version 4.0.1. Fixed by team [PR 4706](https://github.com/nunit/nunit/pull/4706) @@ -34,7 +34,7 @@ There are 31 issues fixed in this release. * [4639](https://github.com/nunit/nunit/issues/4639) `ValueTask` is not being properly consumed by the `AwaitAdapter`. Fixed by team [PR 4640](https://github.com/nunit/nunit/pull/4640) * [4598](https://github.com/nunit/nunit/issues/4598) DefaultTimeout in .runsettings + TearDown method seems to break test output. Fixed by team [PR 4692](https://github.com/nunit/nunit/pull/4692) * [4589](https://github.com/nunit/nunit/issues/4589) Exception when using test filters from .runsettings or --filter argument from dotnet test. Fixed by team [PR 4760](https://github.com/nunit/nunit/pull/4760) -* [4584](https://github.com/nunit/nunit/issues/4584) Nunit 4.0.x Test case selection is incorrect with certain test data. +* [4584](https://github.com/nunit/nunit/issues/4584) Nunit 4.0.x Test case selection is incorrect with certain test data. Fixed by team [PR 4773](https://github.com/nunit/nunit/pull/4773) * [1358](https://github.com/nunit/nunit/issues/1358) TestContext.CurrentContext.Test.Properties does not contain value(s) from PropertyAttribute when using TestCaseAttribute. Fixed by team [PR 4757](https://github.com/nunit/nunit/pull/4757) ### Refactorings @@ -54,6 +54,17 @@ None ### Others +* [4765](https://github.com/nunit/nunit/issues/4765) Document ThrowOnEachFailurUnderDebugger. +* [4730](https://github.com/nunit/nunit/issues/4730) Remove reference to the mailing list from CONTRIBUTING.md. Fixed by team [PR 4752](https://github.com/nunit/nunit/pull/4752) +* [4726](https://github.com/nunit/nunit/issues/4726) `Using<TCollectionType, TMemberType>` is unclear. Thanks to [Michael Render](https://github.com/RenderMichael) for [PR 4729](https://github.com/nunit/nunit/pull/4729) +* [4684](https://github.com/nunit/nunit/issues/4684) Increment StreamsComparer by 'Actual bytes read' rather than the buffer size. Fixed by team [PR 4671](https://github.com/nunit/nunit/pull/4671) + +### The following issues are marked as breaking changes + +None + +### Others + * [4765](https://github.com/nunit/nunit/issues/4765) Document ThrowOnEachFailurUnderDebugger. * [4730](https://github.com/nunit/nunit/issues/4730) Remove reference to the mailing list from CONTRIBUTING.md. Fixed by team [PR 4752](https://github.com/nunit/nunit/pull/4752) * [4726](https://github.com/nunit/nunit/issues/4726) `Using<TCollectionType, TMemberType>` is unclear. Thanks to [Michael Render](https://github.com/RenderMichael) for [PR 4729](https://github.com/nunit/nunit/pull/4729) From 58636b7e7762a3926c5007cfae00d84f36b09bfc Mon Sep 17 00:00:00 2001 From: Steven Weerdenburg Date: Sun, 4 Aug 2024 18:34:21 -0400 Subject: [PATCH 3/5] Update docs/articles/nunit/release-notes/framework.md --- docs/articles/nunit/release-notes/framework.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/articles/nunit/release-notes/framework.md b/docs/articles/nunit/release-notes/framework.md index 91f67a684..cda63ad87 100644 --- a/docs/articles/nunit/release-notes/framework.md +++ b/docs/articles/nunit/release-notes/framework.md @@ -57,7 +57,7 @@ None * [4765](https://github.com/nunit/nunit/issues/4765) Document ThrowOnEachFailurUnderDebugger. * [4730](https://github.com/nunit/nunit/issues/4730) Remove reference to the mailing list from CONTRIBUTING.md. Fixed by team [PR 4752](https://github.com/nunit/nunit/pull/4752) * [4726](https://github.com/nunit/nunit/issues/4726) `Using<TCollectionType, TMemberType>` is unclear. Thanks to [Michael Render](https://github.com/RenderMichael) for [PR 4729](https://github.com/nunit/nunit/pull/4729) -* [4684](https://github.com/nunit/nunit/issues/4684) Increment StreamsComparer by 'Actual bytes read' rather than the buffer size. Fixed by team [PR 4671](https://github.com/nunit/nunit/pull/4671) +* [4684](https://github.com/nunit/nunit/issues/4684) Increment StreamsComparer by 'Actual bytes read' rather than the buffer size. Thanks to [Mithilesh Zavar](https://github.com/mithileshz) for [PR 4671](https://github.com/nunit/nunit/pull/4671) ### The following issues are marked as breaking changes From 1d30ea90b55c0b5edbb83677e1f68c2a12b1b058 Mon Sep 17 00:00:00 2001 From: Steven Weerdenburg Date: Sun, 4 Aug 2024 18:34:32 -0400 Subject: [PATCH 4/5] Update docs/articles/nunit/release-notes/framework.md --- docs/articles/nunit/release-notes/framework.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/articles/nunit/release-notes/framework.md b/docs/articles/nunit/release-notes/framework.md index cda63ad87..cb22a62af 100644 --- a/docs/articles/nunit/release-notes/framework.md +++ b/docs/articles/nunit/release-notes/framework.md @@ -55,7 +55,7 @@ None ### Others * [4765](https://github.com/nunit/nunit/issues/4765) Document ThrowOnEachFailurUnderDebugger. -* [4730](https://github.com/nunit/nunit/issues/4730) Remove reference to the mailing list from CONTRIBUTING.md. Fixed by team [PR 4752](https://github.com/nunit/nunit/pull/4752) +* [4730](https://github.com/nunit/nunit/issues/4730) Remove reference to the mailing list from CONTRIBUTING.md. Fixed by team [PR 4752](https://github.com/nunit/nunit/pull/4751) * [4726](https://github.com/nunit/nunit/issues/4726) `Using<TCollectionType, TMemberType>` is unclear. Thanks to [Michael Render](https://github.com/RenderMichael) for [PR 4729](https://github.com/nunit/nunit/pull/4729) * [4684](https://github.com/nunit/nunit/issues/4684) Increment StreamsComparer by 'Actual bytes read' rather than the buffer size. Thanks to [Mithilesh Zavar](https://github.com/mithileshz) for [PR 4671](https://github.com/nunit/nunit/pull/4671) From f653402e530061ea4800aa81a71132d3ae732a18 Mon Sep 17 00:00:00 2001 From: Steven Weerdenburg Date: Sun, 4 Aug 2024 18:38:14 -0400 Subject: [PATCH 5/5] Update docs/articles/nunit/release-notes/framework.md --- docs/articles/nunit/release-notes/framework.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/articles/nunit/release-notes/framework.md b/docs/articles/nunit/release-notes/framework.md index cb22a62af..fafb1d294 100644 --- a/docs/articles/nunit/release-notes/framework.md +++ b/docs/articles/nunit/release-notes/framework.md @@ -54,7 +54,7 @@ None ### Others -* [4765](https://github.com/nunit/nunit/issues/4765) Document ThrowOnEachFailurUnderDebugger. +* [4765](https://github.com/nunit/nunit/issues/4765) Document ThrowOnEachFailurUnderDebugger. * [4730](https://github.com/nunit/nunit/issues/4730) Remove reference to the mailing list from CONTRIBUTING.md. Fixed by team [PR 4752](https://github.com/nunit/nunit/pull/4751) * [4726](https://github.com/nunit/nunit/issues/4726) `Using<TCollectionType, TMemberType>` is unclear. Thanks to [Michael Render](https://github.com/RenderMichael) for [PR 4729](https://github.com/nunit/nunit/pull/4729) * [4684](https://github.com/nunit/nunit/issues/4684) Increment StreamsComparer by 'Actual bytes read' rather than the buffer size. Thanks to [Mithilesh Zavar](https://github.com/mithileshz) for [PR 4671](https://github.com/nunit/nunit/pull/4671)