[shunjieee] iP

[shunjieee]

Xavier, your Financial Task Advisor

Good Morning. Hustler! ~ Xavier

Xavier frees your mind (I mean take your precious time) of having remember things you need to do. It's,

• text-based
• easy to learn
• fast SUPER DUPER FAST

All you need to do is,

1. download it from here.
2. double-click it.
3. add you tasks.
4. let it manage your tasks for you 😇.

And it is FREE!!!

Features:

• Manage tasks
• Managing deadlines (coming soon)
• Reminders (coming soon... or never 😅)

---

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

[JiaXinEu]

LGTM 👍
Overall, I find your code easy to read and most part follows the coding standards.

[JiaXinEu]

Suggested change

	import helperpackage.Deadline;
	import helperpackage.DukeException;
	import helperpackage.Event;
	import helperpackage.Task;
	import helperpackage.ToDo;
	import java.util.LinkedList;
	import java.util.NoSuchElementException;
	import java.util.Scanner;
	import java.util.StringTokenizer;
	import java.util.LinkedList;
	import java.util.NoSuchElementException;
	import java.util.Scanner;
	import java.util.StringTokenizer;
	import helperpackage.Deadline;
	import helperpackage.DukeException;
	import helperpackage.Event;
	import helperpackage.Task;
	import helperpackage.ToDo;

[JiaXinEu]

I like how you name the Boolean variable 😃

[JiaXinEu]

Suggested change

	int index = Integer.parseInt(st.nextToken());
	Task t = taskList.remove(index - 1);
	System.out.println("Noted, I've removed this task:");
	System.out.println(" " + t.toString());
	System.out.println("Now you have " + taskList.size() + " tasks in the list.");
	}
	int index = Integer.parseInt(st.nextToken());
	Task t = taskList.remove(index - 1);
	System.out.println("Noted, I've removed this task:");
	System.out.println(" " + t.toString());
	System.out.println("Now you have " + taskList.size() + " tasks in the list.");
	}

[JiaXinEu]

I like how you use line wrapping at appropriate place of this line

[ljy0422]

After reviewing your code for naming standards, no significant issues are identified. Nonetheless, there are a couple of spots where tweaking the names could make things a bit clearer. Keep up the great work! :)))

[ljy0422]

Here the description means the whole part following the command type, while in the Task class another description means solely the description part of a task, which would be a little misleading or ambiguous. Would it be better to change the variable name here?

[ljy0422]

The name index doesn't explain its meaning accurately. Could you try to specify what the index stands for, like the firstSpaceIndex in your code above?

[minghowC]

Overall, I found your code is easy to read. LGTM, just a few nits to fix.
For simplicity sake, perpahs line 72 "boolean isDone = Integer.parseInt(tasks[1]) == 1 ? true : false; can be simplified to boolean isDone = Integer.parseInt(tasks[1]) == 1;? Also, perhaps a more intuitive constant variable name here for "T, "D", and "E"?
Pardon my PR at this point of time.