Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid start_url with revision in v3.3.0 #403

Closed
andrewspy opened this issue Nov 29, 2020 · 2 comments · Fixed by elirehema/nbs-web#89 · 4 remaining pull requests
Closed

Invalid start_url with revision in v3.3.0 #403

andrewspy opened this issue Nov 29, 2020 · 2 comments · Fixed by elirehema/nbs-web#89 · 4 remaining pull requests

Comments

@andrewspy
Copy link

v3.3.0 added random per-build revision to sw.js with invalid URL.

Actual start URL: /start_url&revision=xxxxxxxx
Expected start URL: /start_url?revision=xxxxxxxx

Error in chrome as follow:

workbox-precaching.prod.js:1 Uncaught (in promise) bad-precaching-response: bad-precaching-response :: [{"url":"http://localhost:3000/start_url&revision=xxxxxxxx","status":404}]
@pi0 pi0 closed this as completed in 054b8a2 Nov 29, 2020
@pi0
Copy link
Member

pi0 commented Nov 29, 2020

Thanks for report. Fixed in 3.3.1. BTW any reason customizing it?

@andrewspy
Copy link
Author

@pi0 It's working as expected now. Thanks!

In my use case, I need to change the route depending on the type of user (i.e. admin vs user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment