Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set default display #33

Closed
wants to merge 1 commit into from
Closed

Conversation

ricardogobbosouza
Copy link
Collaborator

Resolve #22

@ricardogobbosouza ricardogobbosouza requested a review from pi0 November 9, 2020 22:19
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #33 (ccbe2ab) into master (6346d7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           41        41           
  Branches        12        12           
=========================================
  Hits            41        41           
Impacted Files Coverage Δ
lib/module.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6346d7f...ccbe2ab. Read the comment docs.

@pi0
Copy link

pi0 commented Nov 9, 2020

Thanks for initiative PR @ricardogobbosouza but i don't think it will solve #22. If we preload assets, swapping doesn't makes sense since it is already loaded. If you want to keep this PR open can help to implement :)

@ricardogobbosouza
Copy link
Collaborator Author

Thanks for initiative PR @ricardogobbosouza but i don't think it will solve #22. If we preload assets, swapping doesn't makes sense since it is already loaded. If you want to keep this PR open can help to implement :)

now I got confused 😕
if you can give me a hint of what needs to be done I appreciate it

@ricardogobbosouza ricardogobbosouza changed the title !feat: set default display feat!: set default display Nov 12, 2020
@ricardogobbosouza
Copy link
Collaborator Author

#88

@ricardogobbosouza ricardogobbosouza deleted the feat-set-display branch October 14, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leverage font-display for best performance
2 participants