Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert "refactor: first class HMR support" #817

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

ineshbose
Copy link
Collaborator

Reverts #795 for now

Copy link

nuxt-studio bot commented Feb 28, 2024

Live Preview ready!

Name Edit Preview Latest Commit
TailwindCSS Edit on Studio ↗︎ View Live Preview 26b5a15

@ineshbose ineshbose merged commit 2ae28e5 into main Feb 28, 2024
2 checks passed
@ineshbose ineshbose deleted the revert-795-first-class-hmr branch February 28, 2024 08:17
Copy link

what-the-diff bot commented Feb 28, 2024

PR Summary

  • Typo Fixes and Description Updates in Documentation
    Some typos in the documentation were fixed, and descriptions, including the ones about how to configure and take advantage of utilities provided by the module, were updated to reflect changes made.

  • Updates in Playground Configuration and Theme Files
    The Playground configuration files and theme files have been cleaned up. Certain color definitions and module imports have been removed.

  • Update in Logger
    The logging function has been updated to use a different dependency.

  • Refactoring in Module File
    Extensive changes made in the module. Deprecated options were updated, warnings improved, new utility functions and resolvers were used to handle configuration, templates, and plugins. Setup for a new feature - Vite plugin handling - was added using these utilities. The way Tailwind CSS is handled has been updated significantly.

  • Modification in Resolvers
    A function resolveCSSPath was modified. Certain conditions were updated for resolving paths, and the function now returns a different value.

  • Changes in Template Creation and Management
    Names of certain functions involved in template creation were modified. Import paths were updated and methods of creating and adding templates were simplified and refactored for efficiency.

  • Type Definitions Updated and Added
    Several new type definitions were created and others modified. This has helped increase type safety and readability in the codebase.

  • Utility Function Movements
    Isolated functions and constants that have general-purpose have been moved to a utility file.

  • Viewer Configurations Updated
    How viewer configurations are set up and utilized has been updated, reflecting changes in variable naming and function parameters.

  • New File Addition: Vite HMR
    A new file related to Vite's Hot Module Replacement feature was added, suggesting new feature additions around Vite ecosystem.

@ineshbose ineshbose mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant