Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: also run ecosystem ci on windows #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobiasdiez
Copy link

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Sometimes I run in errors that are specific to windows. Perhaps this is because most of the core developers in the nuxt ecosystemu seem to use linux/macos and the ci tests in the repos are also usually only run on ubuntu.

It would be nice if such errors could be discovered before and not after a new release of a module/nuxt version. For this reason, we activate the ci-ecosystem tests also on windows.

Test run (3.x branch): https://github.com/tobiasdiez/ecosystem-ci/actions/runs/11026454120
Test run (main branch): https://github.com/tobiasdiez/ecosystem-ci/actions/runs/11026329086

There are a few modules that are indeed broken on Windows (but not on ubuntu). Most of these issues seem to be due to nuxtlabs/nuxt-component-meta#72.

@danielroe
Copy link
Member

thank you!

if any of these are reproducible in the module’s main repo we should probably add a windows workflow there as well

@tobiasdiez
Copy link
Author

if any of these are reproducible in the module’s main repo we should probably add a windows workflow there as well

I can at least reproduce the issue coming from nuxt-component-meta in the storybook module (nuxt-modules/storybook#775). I agree, it would make sense to run windows-based workflows in each of the modules themselves. Is this something you can create mass-PRs for using your magic tools? πŸ˜„

@danielroe
Copy link
Member

indeed I could … just not sure how welcome it would be πŸ˜†

@danielroe
Copy link
Member

Happy to do it, but I think we should

  • make the os a selection for on demand test
  • ensure that the os is printed (maybe via emoji) in discord webhook
  • we can then make the test scheduled once everything is green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants