Unsplash images edit problem (pull #712 related) #719
Replies: 1 comment 1 reply
-
|
Your PR got merged, congrats. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Yes. I'm sorry for forgetting. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi everybody, please forgive me if I'm spamming but i recently started using this provider and I observed there was an edge case not handled with the Unsplash provider.
I opened a pull request #712 which handles this case but there has been no action.
Is there something I've done wrong or haven't done that blocks this pull request from been reviewed?
The fact that images are not correctly formatted when passing an url instead of a path is a big problem as I'm using the url of the image returned by the Unsplash api is easier than obtaining the path, plus it keeps the tracking url parameters Unsplash uses for tracking which app produced views and downloads.
Beta Was this translation helpful? Give feedback.
All reactions